octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #56155] [Mac] quit menu item disabled after la


From: Rik
Subject: [Octave-bug-tracker] [bug #56155] [Mac] quit menu item disabled after launch
Date: Thu, 18 Apr 2019 19:54:50 -0400 (EDT)
User-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; Trident/7.0; rv:11.0) like Gecko

Follow-up Comment #12, bug #56155 (project octave):

This bug report requires someone who can build the development version of
Octave for Mac in order to test suggestions like the one in comment #11.  I'm
adding Andrew to the CC list in case he has time.

Reading the Qt Mac OS Issues page, this also may be related/relevant


By default, Qt creates a native Quit menu item that will react to the CMD+Q
shortcut. Creating a QAction for the QAction::QuitRole role will replace that
menu item. Therefore, the replacement action should be connected to either the
QCoreApplication::quit slot, or a custom slot that stops the application.


So, if the suggestion to use setMenuRole does not work (first choice for fix),
a second possibility is to avoid creating the "Exit" option entirely on OSX
platforms.  Something like


#if ! defined (OCTAVE_USE_OS_X_API)
     m_exit_action = file_menu->addAction (tr ("Exit"));
     m_exit_action->setShortcutContext (Qt::ApplicationShortcut);
#endif


Third possibility, since Qt seems to use heuristics based on text, would be to
rename the "Exit" option to "Quit".  This could be done across all platforms,
or just for Macs.  Something like this


#if defined (OCTAVE_USE_OS_X_API)
     m_exit_action = file_menu->addAction (tr ("Quit"));
#else
     m_exit_action = file_menu->addAction (tr ("Exit"));
#endif
     m_exit_action->setShortcutContext (Qt::ApplicationShortcut);


In a very brief survey of applications, I found that the KDE applications seem
to prefer "Quit", LibreOffice used "Exit", Thunderbird used "Quit", and
Firefox used "Quit".


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?56155>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]