[Octave-bug-tracker] [bug #56347] Implement figure "pointer" property

[Rik]

Follow-up Comment #2, bug #56347 (project octave):

This is cool.

I tried it out and made a few changes.

1) I modified some of the documentation in genpropdoc.m to--hopefully?--be
clearer.

2) In libgui/icons/module.mk there was a line to add the icon xterm.png, but I
don't see that anywhere, so I removed it.

3) The pointer shape "fullcrosshair" was removed in Matlab 2014B so I removed
it as a choice from graphics.in.h

4) The default value for "pointerhotspot" was [0,0] which I changed to [1,1]
(top-left)

I found two things that I think need fixing.

#1: weirdly colored pixels when using 16x16 cursors.  The odd pixels are in
ones that should be transparent.

Code to reproduce


clf;
ptr = zeros (16,16);
# Cross shape
ptr (8,:) = 1;
ptr (:,8) = 1;
set (gcf, 'pointershapecdata', ptr);
set (gcf, 'pointer', 'custom');


#2: Changing "pointershapecdata" doesn't automatically update cursor.

Code to reproduce


clf;
# This will make cursor a black square
set (gcf, 'pointer', 'custom');
ptr = zeros (16,16);
# Cross shape
ptr (8,:) = 1;
ptr (:,8) = 1;
set (gcf, 'pointershapecdata', ptr);
# Cursor is still black
# This toggles the cursor and makes it work.
set (gcf, 'pointer', 'arrow');
set (gcf, 'pointer', 'custom');


I uploaded a version 4 of the patch that includes my changes.

(file #46933)
    _______________________________________________________

Additional Item Attachment:

File name: pointer4.cset                  Size:21 KB
    <https://savannah.gnu.org/file/pointer4.cset?file_id=46933>



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?56347>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/