[Octave-bug-tracker] [bug #57049] Mac build failure: CFLocaleCopyCurrent from CoreFoundation not found

[Andrew Janke]

Follow-up Comment #6, bug #57049 (project octave):

That seems like a bit of a hack. CoreFoundation is an indirect dependency:
it's only needed because gnulib uses it. And gnulib provides autoconf stuff to
pull in those libraries. I'd think that if that were working properly and
Octave were using it properly, we'd pick up that framework automatically
through our gnulib linkage, instead of having to pull it in ourselves.

The `m4/intlmacosx.m4` file provided by gnulib and (I think) generated by
running `./bootstrap` contains this autoconf code for picking up
CoreFoundation when CFLocaleCopyCurrent is needed.


  dnl Check for API introduced in Mac OS X 10.5.
  AC_CACHE_CHECK([for CFLocaleCopyCurrent], [gt_cv_func_CFLocaleCopyCurrent],
    [gt_save_LIBS="$LIBS"
     LIBS="$LIBS -Wl,-framework -Wl,CoreFoundation"
     AC_LINK_IFELSE(
       [AC_LANG_PROGRAM(
          [[#include <CoreFoundation/CFLocale.h>]],
          [[CFLocaleCopyCurrent();]])],
       [gt_cv_func_CFLocaleCopyCurrent=yes],
       [gt_cv_func_CFLocaleCopyCurrent=no])
     LIBS="$gt_save_LIBS"])
  if test $gt_cv_func_CFLocaleCopyCurrent = yes; then
    AC_DEFINE([HAVE_CFLOCALECOPYCURRENT], [1],
      [Define to 1 if you have the Mac OS X function CFLocaleCopyCurrent in
the CoreFoundation framework.])
  fi

[...]

  INTL_MACOSX_LIBS=
  if test $gt_cv_func_CFPreferencesCopyAppValue = yes \
     || test $gt_cv_func_CFLocaleCopyCurrent = yes \
     || test $gt_cv_func_CFLocaleCopyPreferredLanguages = yes; then
    INTL_MACOSX_LIBS="-Wl,-framework -Wl,CoreFoundation"
  fi
  AC_SUBST([INTL_MACOSX_LIBS])


It seems to me that that is where Octave should be picking up CoreFoundation.
I'm not enough of an autoconf expert to trace through this and figure out
what's going on, though.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?57049>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/