[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #57353] crash signal 11 when using patch() wit
From: |
John W. Eaton |
Subject: |
[Octave-bug-tracker] [bug #57353] crash signal 11 when using patch() with large stl file |
Date: |
Thu, 5 Dec 2019 22:27:41 -0500 (EST) |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0 |
Follow-up Comment #31, bug #57353 (project octave):
Thanks for finding a fix for this problem.
I pushed an additional change to use "std::vector<std::vector<T>> (SIZE)"
instead of "new std::vector<T> [SIZE]" so that the object will be cleaned when
it goes out of scope even if that happens because an exception occurs. In
Octave, we generally want to limit use of new to constructors and delete to
destructors.
Also, std::vector<std::vector<RowVector>> is a bit of a strange data
structure, so maybe there is a better way to express what we are trying to do
in that function? But, for now, I left it as is since it seems to work.
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?57353>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
- [Octave-bug-tracker] [bug #57353] crash signal 11 when using patch() with large stl file, (continued)
- [Octave-bug-tracker] [bug #57353] crash signal 11 when using patch() with large stl file, Hg200, 2019/12/05
- [Octave-bug-tracker] [bug #57353] crash signal 11 when using patch() with large stl file, Markus Mützel, 2019/12/05
- [Octave-bug-tracker] [bug #57353] crash signal 11 when using patch() with large stl file, Hg200, 2019/12/05
- [Octave-bug-tracker] [bug #57353] crash signal 11 when using patch() with large stl file, Rik, 2019/12/05
- [Octave-bug-tracker] [bug #57353] crash signal 11 when using patch() with large stl file, Marcel Hell, 2019/12/05
- [Octave-bug-tracker] [bug #57353] crash signal 11 when using patch() with large stl file, Marcel Hell, 2019/12/05
- [Octave-bug-tracker] [bug #57353] crash signal 11 when using patch() with large stl file, Hg200, 2019/12/05
- [Octave-bug-tracker] [bug #57353] crash signal 11 when using patch() with large stl file, Rik, 2019/12/05
- [Octave-bug-tracker] [bug #57353] crash signal 11 when using patch() with large stl file, Marcel Hell, 2019/12/05
- [Octave-bug-tracker] [bug #57353] crash signal 11 when using patch() with large stl file, Rik, 2019/12/05
- [Octave-bug-tracker] [bug #57353] crash signal 11 when using patch() with large stl file,
John W. Eaton <=
- [Octave-bug-tracker] [bug #57353] crash signal 11 when using patch() with large stl file, Rik, 2019/12/06
- [Octave-bug-tracker] [bug #57353] crash signal 11 when using patch() with large stl file, Markus Mützel, 2019/12/06
- [Octave-bug-tracker] [bug #57353] crash signal 11 when using patch() with large stl file, John W. Eaton, 2019/12/06
- [Octave-bug-tracker] [bug #57353] crash signal 11 when using patch() with large stl file, Rik, 2019/12/06
- [Octave-bug-tracker] [bug #57353] crash signal 11 when using patch() with large stl file, John W. Eaton, 2019/12/06