[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #57522] "pkg unload" does not care for depende

From: Mike Miller
Subject: [Octave-bug-tracker] [bug #57522] "pkg unload" does not care for dependencies
Date: Thu, 23 Jan 2020 14:15:29 -0500 (EST)
User-agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.130 Safari/537.36

Follow-up Comment #23, bug #57522 (project octave):

I haven't applied and tested this patch yet, but I still see some edits and
style problems that need fixing. But this looks much better, much simpler, and
the functionality looks right to me. Thank you for pursuing this and cleaning
up the code.

* Please don't delete the texinfo doc string blocks for the private functions
'describe' and 'unload_packages'. Deleted accidentally?

* Please fix the hyphen typo in the commit message mentioning

* Why force a line break with '@*' in the middle of the text added to the
pkg.m doc string? It looks fine to me without it.

* The 'endfor' in describe.m seems to have been accidentally unindented.

* We aren't using the 'Author' and 'Created' comments in Octave source files
any more, please delete that comment. And the extra line before '@end
deftypefn' in the texinfo doc string should be deleted.

* There are still a few cases of 'cellfun (... "uni", 0)', please expand those
to the full syntax.

* Please use space around the equals sign in expressions like 'for ii = ...'.
I'm personally not a fan of variables named 'ii' and 'jj', but that's fine, we
have them elsewhere.

* Error messages should be prefixed with "pkg: ", not "pkg.m: ".

* Multi-line error messages should be split into concatenated strings with
'...', see similar errors in pkg.m and test.m.


Reply to this item at:


  Message sent via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]