[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #57867] strrep: unexpected substitution behavi

From: Nicholas Jankowski
Subject: [Octave-bug-tracker] [bug #57867] strrep: unexpected substitution behavior on a char array
Date: Wed, 18 Mar 2020 20:33:56 -0400 (EDT)
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.149 Safari/537.36

Follow-up Comment #9, bug #57867 (project octave):

thanks. I realized when posting my last comment that the Post a Comment box is
actually hidden by default, and it might not be obvious to everyone how to
contribute to the discussion. This summer we've had 3-4 people post files to a
bug without commentary, and thus far they all turned into frustrating learning
experiences.  Glad you're sticking with this one.

This bug is to correct a function that already exists. So the correction would
likely be a modification to the existing function.  So: 

Are you at all familiar with Octave? Do you have the program installed?

Have you looked at the Source code? Have you cloned the source code in
Mercurial and are you able to set things up to build Octave from source? 

The function in question (strrep) is a function from the file strfind.cc. 
inside of octave you can find the location of any function using the 'which'

>> which strrep
'strrep' is a built-in function from the file libinterp/corefcn/strfind.cc

Inside the source tree, you can then find that file and make changes to the
source file directly. We use Mercurial so that changesets / patches can be
generated by your changes, we post those to the bug tracker, and then others
can apply and test out your patch. Primary maintainers of the source code can
then decide when the patch is ready to be applied. 

The primary concern I see with your changes thus far is that they make more
than the minimal changes required to fix the bug. Octave strives to have
Matlab compatible code, and because there already exists a matlab function
strrep, we do not want to split it out into two functions and change the
calling syntax. 

Some of the development rules:

- strive for Matlab compatibility, and treat incompatibility as a bug unless
you have a really good reason not to do so.
- you can use the public facing Matlab documentation to set expected behavior,
and can request some input/output compatibility tests, but for copyright
reasons should never look at the source code of matlab functions.
Contributions can be disallowed for that reason alone.
- see links in comment #3 for guidelines on code contribution.


Reply to this item at:


  Message sent via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]