[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #57641] pkg install fails for noexec /tmp

From: Mike Miller
Subject: [Octave-bug-tracker] [bug #57641] pkg install fails for noexec /tmp
Date: Sat, 21 Mar 2020 16:22:04 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.149 Safari/537.36

Update of bug #57641 (project octave):

                  Status:               Confirmed => Patch Submitted        


Follow-up Comment #10:

Thanks for writing the patch. This is not a full review, and I haven't tested,
just a few "at a glance" comments.

There should be a space after the '!' unary operator.

The error message could be a little clearer, probably needs to be a little
more verbose, something like "pkg: unable to execute temporary files in
directory %s, try 'setenv TMPDIR ...' to use a different directory". We
usually break long error messages like this

  error (["pkg: long error message " ...
          "continues here"]);

I think the call to 'chmod' could use 'system' instead of 'shell', it would be
better to use 'system' when possible.

I'm also not sure how this will work on Windows, or whether it's even
necessary, needs someone with Windows to test.

Also our commit messages are short and only describe "what" was changed, not
"why" it was changed. See for example this commit message:


Reply to this item at:


  Message sent via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]