octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #57794] cart2sph, sph2cart: output argument sh


From: Rik
Subject: [Octave-bug-tracker] [bug #57794] cart2sph, sph2cart: output argument should not change behavior with different nargout
Date: Tue, 24 Mar 2020 15:48:12 -0400 (EDT)
User-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; Trident/7.0; rv:11.0) like Gecko

Update of bug #57794 (project octave):

                  Status:         Patch Submitted => Fixed                  
             Open/Closed:                    Open => Closed                 

    _______________________________________________________

Follow-up Comment #9:

I reviewed the patch and pushed it to the development branch here
https://hg.savannah.gnu.org/hgweb/octave/rev/a23da76e0693.

I made a few modifications.  The '\frac' LaTex command was not supported on my
machine so I re-wrote to use '\over' which is what the rest of the manual
uses.

The removal of the one output argument for the coordinate functions caused
bugs in surfl.m and lightangle.m so I re-did the code there to use the new
syntax.

I also moved input validation to be first in the function whenever possible.

Thanks for contributing the patch.  Marking as fixed and closing report.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?57794>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]