[Octave-bug-tracker] [bug #58320] [mxe-octave] Add ability to specify a local or allusers install from the installer

[Markus Mützel]

Follow-up Comment #21, bug #58320 (project octave):

I tried with creating an installer with your latest patch from comment #19.
The installation as an unprivileged user works like before. 
Also Octave seems to run fine.
When I try to uninstall from "Apps and Features", I am prompted to
authenticate as an admin. After that, I still see the same dialog as with the
previous patch.

I also tried with the following change on top of your patch:

diff -r 779a4cf71d46 -r 0911c7c8fb4d tools/makeinst-script.sh.in
--- a/tools/makeinst-script.sh.in       Sun May 17 22:15:34 2020 -0400
+++ b/tools/makeinst-script.sh.in       Wed May 20 20:00:13 2020 +0200
@@ -305,9 +305,9 @@
   # if 0 it couldnt find us
   StrCmp \$R0 0 0 uninst_check_local
 
-\${if} \$MultiUser.Privileges == "Admin"
+\${if} \$MultiUser.InstallMode == "CurrentUser"
   # if admin, maybe was forced to admin from Add Remove Apps
-  MessageBox MB_ICONEXCLAMATION|MB_OK "Could not find matching install in
registry.\$\nTry running the unistaller from the start menu or installed
folder \$INSTDIR" /SD IDOK
+  MessageBox MB_ICONEXCLAMATION|MB_OK "Could not find matching install in
registry.\$\nTry running the uninstaller from the start menu or from the
installation folder \"\$INSTDIR\"." /SD IDOK
 \${Else}
   MessageBox MB_ICONEXCLAMATION|MB_OK "Could not find matching install in
registry for \$(^Name) using \$INSTDIR - Can not uninstall!" /SD IDOK
 \${EndIf}


With an installer generated with that change, I still don't see the
alternative error message when trying to uninstall from "Apps and Features".

Additionally: Do we have to somehow catch the case that both the unprivileged
user and the admin have a local installation (that the admin does not want to
uninstall)? Or is this use case too academic, and the current logic is good
enough?

Alternatively, would it be possible to *not* register the uninstaller in the
registry for a local installation? Providing the uninstall link in the start
menu could be good enough imho.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?58320>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/