[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #58942] [octave forge] (io) version 2.6.1 read
[Octave-bug-tracker] [bug #58942] [octave forge] (io) version 2.6.1 read cell range data from worksheet
Fri, 4 Sep 2020 11:34:51 -0400 (EDT)
Mozilla/5.0 (Windows NT 6.1; rv:52.0) Gecko/20100101 Firefox/52.0
Follow-up Comment #4, bug #58942 (project octave):
Can you please explain what bug you saw, and how your patch will fix that bug?
Do you have a reproducible scenario?
AFAIU there are a few intermingled things in your report:
* You got an error message "error: xls2oct: worksheet number 1 > number of
worksheets in file (0)"
That implies that xls2oct.m didn't find a worksheet. AFAICS the only way that
can happen is if you opened a new file, didn't add any data to it and then
tried to read from it.
* Your patch allows to skip specifying a worksheet in xls2oct.m; the same is
done in xlsread.m so there's already a similar mechanism in place. I'm not
fond of having similar measures in different parts of the io package code
I'm afraid that _if_ you hit a real bug your fix is just fixing symptoms but
not a real fix for the underlying issue.
As I couldn't detect any issues in the io package code I intend to close this
report with "invalid" but I wouldn't want to let a real bug pass into a next
io package release.
Reply to this item at:
Message sent via Savannah
|[Prev in Thread]
||[Next in Thread]|
- [Octave-bug-tracker] [bug #58942] [octave forge] (io) version 2.6.1 read cell range data from worksheet,
Philip Nienhuis <=