[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #59121] jsonencode needs functional BIST tests
Abdallah Khaled Elshamy
[Octave-bug-tracker] [bug #59121] jsonencode needs functional BIST tests for case when "PrettyWriter" is true
Fri, 18 Sep 2020 18:13:12 -0400 (EDT)
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:80.0) Gecko/20100101 Firefox/80.0
Follow-up Comment #4, bug #59121 (project octave):
Since those functions were my GSoC project with Octave, I can supply more
> You're right that this probably needs some more comments. I think what the
programmer had in mind is that this script could be run under Matlab to verify
that the results were equivalent in Octave. To do so, the m-file should be
left in Matlab syntax so '%' for comment character, no specialized 'end'
blocks like 'endif', etc.
That's right. Actually, The tests were originally written in MATLAB then
converted to Octave's BIST since MATLAB compatibility was a goal of my
project. We (me and my mentors) decided to leave it in external files so that
we can check if the compatibility is broken in the newer versions of MATLAB.
Regarding the need for "PrettyWriter" tests, I didn't add tests for it
* The only difference between it and the "normal" writer is the adding of some
indentations and new lines but the content is basically the same so the tests
seemed to trivial to me.
* This difference is made internally in "RapidJSON" and not in a code written
in Octave and I think it is not a good idea to test for things that we didn't
write. RapidJSON may change the "pretty" format in the future releases and
those tests will fail.
However, If you think that we still need them, I would be happy to help with
Reply to this item at:
Message sent via Savannah