[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #59135] jsondecode converts logical arrays to

From: Rik
Subject: [Octave-bug-tracker] [bug #59135] jsondecode converts logical arrays to numeric arrays
Date: Mon, 28 Sep 2020 11:30:51 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/85.0.4183.83 Safari/537.36

Update of bug #59135 (project octave):

                  Status:         Patch Submitted => Fixed                  
             Open/Closed:                    Open => Closed                 


Follow-up Comment #4:

Thank you Abdallah.  I verified the patch and checked it in here

I made a few small changes.  Octave uses spaces, rather than tabs, because the
tabstop setting is never the same between computers and this always leads to
mis-indented code.  Also, in the commit message one usually writes what was
done and where it was done (function name), rather than just the result.  So I
changed "Fix bug" (result) to "* jsondecode.cc (decode_array_of_arrays): Check
value of is_bool and return
either boolNDArray (logical) or NDArray (numeric)."

I'm marking this bug as fixed and closing it.  Unfortunately, while testing I
found that multi-dimensional logical arrays are encoded to multi-dimensional
numeric arrays.  I'll file a new bug report about that.


Reply to this item at:


  Message sent via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]