octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #59277] [octave-forge](io) xls2oct is slow whe


From: Philip Nienhuis
Subject: [Octave-bug-tracker] [bug #59277] [octave-forge](io) xls2oct is slow when a spreadsheet contains many text cells
Date: Sun, 25 Oct 2020 17:01:59 -0400 (EDT)
User-agent: Mozilla/5.0 (Windows NT 6.1; rv:52.0) Gecko/20100101 Firefox/52.0

Update of bug #59277 (project octave):

                  Status:             In Progress => Fixed                  
             Open/Closed:                    Open => Closed                 

    _______________________________________________________

Follow-up Comment #26:

As a last action for this bug report I overhauled the code that transforms the
combined regexp output into the raw output array.

Next I ran it with my testscript that checks the local bug spreadsheet
collection, it looks like:

xfl = {(dir ("*.xlsx")).name}
xsz = [(dir ("*.xlsx")).bytes]
for ii=1:numel (xfl)
  [~, sheets] = xlsfinfo (xfl{ii}, "oct");
  for jj=1:size (sheets, 1)
    printf ("File %s, sheet %s, size %d, time ", xfl{ii}, sheets{jj, 1},
xsz(ii));
    tic;
    [num, txt, raw, lims] = xlsread (xfl{ii}, sheets{jj, 1}, "", "oct");
    printf ("%f\n", toc);
  endfor
endfor


For smaller spreadsheets the speed gains seem negligible but for larger ones,
esp. with many strings, speed gains are impressive.

Attached is the  __OCT_xlsx2oct__.m  file I finally pushed here (previous
improvements have been pushed earlier on):
http://hg.code.sf.net/p/octave/io/rev/3adc77a99b7b
If you want you can benchmark if you get still better performance than the
version you made up in comment #24.

I'm curious, you can post your findings even while I'm going to close this bug
report anyway; like you I think that most of the potential performance gains
have been implemented.

Many thanks for your cooperation and suggestions.


(file #50099)
    _______________________________________________________

Additional Item Attachment:

File name: __OCT_xlsx2oct__.m             Size:9 KB
    <https://file.savannah.gnu.org/file/__OCT_xlsx2oct__.m?file_id=50099>



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?59277>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]