|
| From: | Markus Mützel |
| Subject: | [Octave-bug-tracker] [bug #57641] pkg install fails for noexec /tmp |
| Date: | Fri, 30 Oct 2020 11:50:23 -0400 (EDT) |
| User-agent: | Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.111 Safari/537.36 Edg/86.0.622.56 |
Follow-up Comment #14, bug #57641 (project octave):
I haven't tested the patch in comment #13 yet. But some preliminary comments:
IIUC, the used commands won't work cross-platform. Maybe `supports_execution`
could return early with `true` if `isunix ()` is false.
You should check if the file handle `f` is valid before using it.
Maybe use an unwind_protect block around `system` and `shell` to unlink the
file even if something went wrong.
Use a space after unary `!`.
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?57641>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
| [Prev in Thread] | Current Thread | [Next in Thread] |