[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #62910] [octave forge] (image) bwslect(..., 4)

From: Hartmut
Subject: [Octave-bug-tracker] [bug #62910] [octave forge] (image) bwslect(..., 4) in Octave behaves like bwslect(..., 8) in MATLAB and vice versa
Date: Sat, 24 Sep 2022 06:31:44 -0400 (EDT)

Follow-up Comment #2, bug #62910 (project octave):

Thanks for finding and fixing this, Avinoam!

I have reviewed your patch in comment #1:
* It fixes the bug from the demo code in comment #0
* It adds a couple of unit tests to bwselect.m. They all pass.
* All new unit tests are Matlab compatible in their results. (but see below)
* All unit tests in bwfill also still pass after this change in bwselect.

I would suggest some small improvements before pushing the patch to the repo:
* In Matlab a call like "bwselect (A, 3, 3)" returns an image handle and no
number array. To improve the Matlab compatibility of the new unit tests, you
could change this to "out = bwselect (A, 3, 3)" and then use the "out" value
in the call to assert.
* There are some missing spaces after the function names "zeros" and "logical"
in the new unit tests.
* Please announce the changed behavior of bwselect in the NEWS file.

Since this patch does change the function behavior, in my opinion it should go
the the default branch of the image repository.


Reply to this item at:


Message sent via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]