[Octave-bug-tracker] [bug #67203] imfinfo does not import full EXIF data from a jpeg file

[Dmitri A. Sergatskov]

Follow-up Comment #7, bug #67203 (group octave):

Attached is a combined diff that fixes error in reading "FileSource" tag and
adding "ISO" and "ISOSpeedRatings" tags.
(file das_magick_00.diff). The diff is very small, I vote to apply it to
stable branch (10.3).


diff -r d72e56ced110 libinterp/corefcn/__magick_read__.cc
--- a/libinterp/corefcn/__magick_read__.cc      Thu Jun 12 10:23:48 2025
+0200
+++ b/libinterp/corefcn/__magick_read__.cc      Thu Jun 12 21:30:13 2025
-0400
@@ -2182,6 +2182,9 @@
               // be strings.  Even if they're not GM returns a string
anyway.
               "UserComment",
               "MakerComment",
+             //FIXME: This should be "int" but it is usually stored in oct
+             // format (e.g. `\003`) and that breaks "fill_exif_ints ()"
+              "FileSource",
               nullptr
             };
             static const string_vector exif_str (exif_str_fields);
@@ -2198,7 +2201,9 @@
               "PhotographicSensitivity",
               "StandardOutputSensitivity",
               "RecommendedExposureIndex",
+              "ISO",
               "ISOSpeed",
+              "ISOSpeedRatings",
               "ISOSpeedLatitudeyyy",
               "ISOSpeedLatitudezzz",
               "FocalPlaneResolutionUnit",
@@ -2216,7 +2221,6 @@
               "LightSource",
               "Flash",
               "SensingMethod",
-              "FileSource",
               "CustomRendered",
               "ExposureMode",
               "WhiteBalance",


Dmitri.
-- 


(file #57291)

    _______________________________________________________

Additional Item Attachment:

File name: das_magick_00.diff             Size: 1KiB
    <https://file.savannah.gnu.org/file/das_magick_00.diff?file_id=57291>


    AGPL NOTICE

These attachments are served by Savane. You can download the corresponding
source code of Savane at
https://savannah.gnu.org/source/savane-e283fc1e831e1a9d7ef799b94eb90b95407712b3.tar.gz


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?67203>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/

signature.asc
Description: PGP signature