Re: union structures for 64 bit octave

[Clinton Chee]

Hi David,

Thanks for your email and the changes you suggested. I'm not too clear
about the function of unwind_protect, why is it trying to protect some
variables.

>>
> Does unwind_protect protect octave_idx_type variables? That is the real
> question. If so then the type index should be added to the enum var_type
> and the unions about should become
> 

To answer your question above, I did a grep on where the code uses
"unwind_protect_int" and the results are shown below. Please correct me
if I'm wrong, but those variables that are protected below, does not
seem to need to be in octave_idx_type. It seems the variables (eg
error_state, warning_state) can be "int"s



oct-hist.cc:490:  unwind_protect_int (Vecho_executing_commands);
oct-hist.cc:519:  unwind_protect_int (Vecho_executing_commands);
ov-struct.cc:395:  unwind_protect_int (Vstruct_levels_to_print);
ov-usr-fcn.cc:342:  unwind_protect_int (call_depth);
ov-usr-fcn.cc:417:  unwind_protect_int (num_args_passed);
ov-usr-fcn.cc:420:  unwind_protect_int (curr_va_arg_number);
parse.cc:4061:  unwind_protect_int (error_state);
parse.cc:4062:  unwind_protect_int (warning_state);
parse.cc:4111:  unwind_protect_int (error_state);
parse.cc:4112:  unwind_protect_int (warning_state);
parse.cc:4162:  unwind_protect_int (error_state);
parse.cc:4163:  unwind_protect_int (warning_state);
parse.cc:5209:  unwind_protect_int (error_state);
parse.cc:5210:  unwind_protect_int (warning_state);
parse.cc:5403:      unwind_protect_int (input_line_number);
parse.cc:5404:      unwind_protect_int (current_input_column);
parse.cc:5699:  unwind_protect_int (input_line_number);
parse.cc:5700:  unwind_protect_int (current_input_column);
parse.cc:5701:  unwind_protect_int (end_tokens_expected);
parse.cc:5731:    unwind_protect_int (Vecho_executing_commands);
parse.cc:6160:    unwind_protect_int (buffer_error_messages);
parse.cc:6293:            unwind_protect_int (buffer_error_messages);
pt-arg-list.cc:206:       unwind_protect_int (index_position);
pt-except.cc:103:      unwind_protect_int (buffer_error_messages);
pt-except.cc:163:  unwind_protect_int (error_state);
pt-except.cc:171:  unwind_protect_int (tree_return_command::returning);
pt-except.cc:174:  unwind_protect_int (tree_break_command::breaking);
variables.cc:447:         unwind_protect_int (error_state);
variables.cc:448:         unwind_protect_int (warning_state);
variables.cc:491:      unwind_protect_int (error_state);


Thanks.

Clinton