[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Bug with pkg if only a single file is installed

From: John W. Eaton
Subject: Re: Bug with pkg if only a single file is installed
Date: Wed, 13 Sep 2006 21:38:14 -0400

On 13-Sep-2006, Søren Hauberg wrote:

| I'm not sure I understand the problem, and I don't see how the patch
| solves it (I've had a loong day at work). 
| Basicly you want to add
|   mkdir(desc.dir)
| to the function 'copy_files'. The way I read the source (it's been a
| while since I wrote it) the function 'prepare_installation' should've
| done this already. I don't quite see what this has to do with only a
| single file needs copying.
| I do however see a potential bug, that your patch fixes. If you install
| a package that replaces an old installation (an upgrade) things will
| fail (I think). The following will happen:
|   1) 'prepare_installation' will create the desc.dir directory.
|   2) 'uninstall' will remove the the desc.dir directory.
|   3) The installation will fail because desc.dir no longer exists.
| I think this is the bug your fixing. So I think the patch should be
| good, except the function 'prepare_installation' shouldn't create the
| desc.dir directory if the patch is accepted.

OK, please check in the changes once you've decided what is the best



reply via email to

[Prev in Thread] Current Thread [Next in Thread]