[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: pkg Patches

From: John Swensen
Subject: Re: pkg Patches
Date: Mon, 09 Oct 2006 17:38:35 -0400
User-agent: Thunderbird (Macintosh/20060909)

John W. Eaton wrote:
On  8-Oct-2006, Bill Denney wrote:

| So, I was working on packaging object graphics, and while doing that, I | found a bug in the package script where it was not showing an error | correctly. I went through and fixed the errors given (most of the patch | is just removing \n from the end of each error string). | | I also rewrote the compare_versions function and pulled it out of pkg (I | think it's generally useful, perhaps in the strings directory). It can | now compare arbitrarily long version numbers with strings appended using | any boolean operator. I'm not including this as a patch because I'm not | sure how to make a patch via cvs after a first change, and I know that | it's best to keep separate changes separate. Before applying this, | please remove the compare_versions function from within pkg.

OK, I applied this patch.



I think this patch broke something. In the Changelog is says you removed the 'compare_versions()' function, but there are 2 places in the 'get_unsatisfied_deps()' function that still try to call it. Has the function been moved elsewhere or eliminated altogether?

John Swensen

reply via email to

[Prev in Thread] Current Thread [Next in Thread]