octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: improved surface: __go_draw_axes__


From: David Bateman
Subject: Re: improved surface: __go_draw_axes__
Date: Wed, 07 Nov 2007 22:07:38 +0100
User-agent: Thunderbird 1.5.0.7 (X11/20060921)

John W. Eaton wrote:
> On  7-Nov-2007, David Bateman wrote:
> 
> | Ok, here is a patch that adds a surfc and matlab compatible pie
> | function, and adds the missing functions the the SOURCES in the Makefile
> 
> I applied this patch.  Thanks.
> 
> In __pie__, I see
> 
>   function hlist = __pie__ (varargin)
> 
>     h = varargin{1};
>     x = abs (varargin{2});
>     iarg = 3;
> 
> and iarg is used to index varargin later in the function.  Is there
> any reason not to write
> 
>   function hlist = __pie__ (h, x, varargin)
> 
>     x = abs (x);
> 
>     iarg = 1;
> 
> or even simply require that all elements of x are positive?
> 
> jwe
> 

Only that I compare it directly to nargin and not nargin-2.. Either way
is fine with me. Note I sent an updated version of this patch with,
demos for pie, a quiver function and documentation in plot.txi just a
minute or so ago.

D.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]