Re: 3.0.1 release? (failed build on OSX)

[John W. Eaton]

On  4-Apr-2008, Ben Abbott wrote:

|  
| On Friday, April 04, 2008, at 11:55AM, "John W. Eaton" <address@hidden> wrote:
| >On  4-Apr-2008, Ben Abbott wrote:
| >
| >| The "osx_fix" script comments out the "INSTANTIATE_ARRAY_AND_ASSIGN\ 
(std::streamoff,\ OCTAVE_API" in /iboctave/Array-so.cc.
| >
| >Since you are now coming up with undefined symbols, have you tried
| >building without first running this script?  What happens then?
| >
| >Also, when you first reported the problem, you didn't mention this
| >local modification.  It might have helped to explain that in the first
| >message...
| >
| >jwe
| >
| 
| Sorry about not mentioning the modification for OSX.
| 
| After returning Array-so.cc to it's original state, "make" ran to completion. 
However, "make check" ended with the error below.
| 
|   test_diffeq.m ..........................................At line 1139 of 
file dlsode.f
| Fortran runtime error: Array reference out of bounds for array 'y', upper 
bound of dimension 1 exceeded (2 > 1)
| make[2]: *** [check] Error 2
| make[1]: *** [check] Error 2
| make: *** [check] Error 2
| 
| Ben

I applied changeset d20a2f261306 (see below) to the release-3-0-x
branch.  Does that help?

jwe


# HG changeset patch
# User John W. Eaton <address@hidden>
# Date 1205170201 14400
# Node ID d20a2f261306cf26375717c45d40736fb1c0a1ac
# Parent  9669b69e34ef0105bd193575e6bb0556c9a5d4bb
use * instead of 1 for assumed-size fortran arrays

diff --git a/libcruft/ChangeLog b/libcruft/ChangeLog
--- a/libcruft/ChangeLog
+++ b/libcruft/ChangeLog
@@ -1,3 +1,10 @@ 2008-03-06  Jaroslav Hajek <address@hidden
+2008-03-10  John W. Eaton  <address@hidden>
+
+       * blas/zdrot.f, odepack/dlsode.f, odepack/ewset.f,
+       odepack/intdy.f, fftpack/cffti.f, fftpack/cfftb.f,
+       fftpack/cfftf.f:
+       Use (*) instead of (1) for assumed-size dimensions.
+
 2008-03-06  Jaroslav Hajek <address@hidden>
 
        * qrupdate/dqrinc.f: Declare DGEMV external.
diff --git a/libcruft/blas/zdrot.f b/libcruft/blas/zdrot.f
--- a/libcruft/blas/zdrot.f
+++ b/libcruft/blas/zdrot.f
@@ -4,7 +4,7 @@ c     double precision and the vectors z
 c     double precision and the vectors zx and zy are double complex.
 c     jack dongarra, linpack, 3/11/78.
 c
-      double complex zx(1),zy(1),ztemp
+      double complex zx(*),zy(*),ztemp
       double precision c,s
       integer i,incx,incy,ix,iy,n
 c
diff --git a/libcruft/daspk/ddaspk.f b/libcruft/daspk/ddaspk.f
--- a/libcruft/daspk/ddaspk.f
+++ b/libcruft/daspk/ddaspk.f
@@ -55,7 +55,7 @@ C     *   IDID, RWORK, LRW, IWORK, LIW, 
 C     *   IDID, RWORK, LRW, IWORK, LIW, RPAR, IPAR, JAC, PSOL)
 C
 C  Quantities which may be altered by the code are:
-C     T, Y(*), YPRIME(*), INFO(1), RTOL, ATOL, IDID, RWORK(*), IWORK(*)
+C     T, Y(*), YPRIME(*), INFO(*), RTOL, ATOL, IDID, RWORK(*), IWORK(*)
 C
 C
 C *Arguments:
diff --git a/libcruft/fftpack/cfftb.f b/libcruft/fftpack/cfftb.f
--- a/libcruft/fftpack/cfftb.f
+++ b/libcruft/fftpack/cfftb.f
@@ -1,6 +1,6 @@
       subroutine cfftb (n,c,wsave)
       implicit double precision (a-h,o-z)
-      dimension       c(1)       ,wsave(1)
+      dimension       c(*)       ,wsave(*)
       if (n .eq. 1) return
       iw1 = n+n+1
       iw2 = iw1+n+n
diff --git a/libcruft/fftpack/cfftf.f b/libcruft/fftpack/cfftf.f
--- a/libcruft/fftpack/cfftf.f
+++ b/libcruft/fftpack/cfftf.f
@@ -1,6 +1,6 @@
       subroutine cfftf (n,c,wsave)
       implicit double precision (a-h,o-z)
-      dimension       c(1)       ,wsave(1)
+      dimension       c(*)       ,wsave(*)
       if (n .eq. 1) return
       iw1 = n+n+1
       iw2 = iw1+n+n
diff --git a/libcruft/fftpack/cffti.f b/libcruft/fftpack/cffti.f
--- a/libcruft/fftpack/cffti.f
+++ b/libcruft/fftpack/cffti.f
@@ -1,6 +1,6 @@
       subroutine cffti (n,wsave)
       implicit double precision (a-h,o-z)
-      dimension       wsave(1)
+      dimension       wsave(*)
       if (n .eq. 1) return
       iw1 = n+n+1
       iw2 = iw1+n+n
diff --git a/libcruft/odepack/dlsode.f b/libcruft/odepack/dlsode.f
--- a/libcruft/odepack/dlsode.f
+++ b/libcruft/odepack/dlsode.f
@@ -3,7 +3,7 @@
       EXTERNAL F, JAC
       INTEGER NEQ, ITOL, ITASK, ISTATE, IOPT, LRW, IWORK, LIW, MF
       DOUBLE PRECISION Y, T, TOUT, RTOL, ATOL, RWORK
-      DIMENSION NEQ(1), Y(1), RTOL(1), ATOL(1), RWORK(LRW), IWORK(LIW)
+      DIMENSION NEQ(*), Y(*), RTOL(*), ATOL(*), RWORK(LRW), IWORK(LIW)
 C-----------------------------------------------------------------------
 C THIS IS THE MARCH 30, 1987 VERSION OF 
 C LSODE.. LIVERMORE SOLVER FOR ORDINARY DIFFERENTIAL EQUATIONS.
diff --git a/libcruft/odepack/ewset.f b/libcruft/odepack/ewset.f
--- a/libcruft/odepack/ewset.f
+++ b/libcruft/odepack/ewset.f
@@ -9,7 +9,7 @@ C---------------------------------------
       INTEGER N, ITOL
       INTEGER I
       DOUBLE PRECISION RTOL, ATOL, YCUR, EWT
-      DIMENSION RTOL(1), ATOL(1), YCUR(N), EWT(N) 
+      DIMENSION RTOL(*), ATOL(*), YCUR(N), EWT(N) 
 C
       GO TO (10, 20, 30, 40), ITOL
  10   CONTINUE
diff --git a/libcruft/odepack/intdy.f b/libcruft/odepack/intdy.f
--- a/libcruft/odepack/intdy.f
+++ b/libcruft/odepack/intdy.f
@@ -9,7 +9,7 @@ CLLL. OPTIMIZE
       DOUBLE PRECISION ROWNS, 
      1   CCMAX, EL0, H, HMIN, HMXI, HU, RC, TN, UROUND
       DOUBLE PRECISION C, R, S, TP
-      DIMENSION YH(NYH,1), DKY(1)
+      DIMENSION YH(NYH,*), DKY(*)
       COMMON /LS0001/ ROWNS(209),
      2   CCMAX, EL0, H, HMIN, HMXI, HU, RC, TN, UROUND,
      3   IOWND(14), IOWNS(6),