octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: polyfit: add a third output argument, mu [PATCH]


From: David Bateman
Subject: Re: polyfit: add a third output argument, mu [PATCH]
Date: Tue, 01 Jul 2008 08:23:42 +0200
User-agent: Thunderbird 2.0.0.12 (X11/20080306)

Dmitri A. Sergatskov wrote:
> On Mon, Jun 30, 2008 at 1:52 PM, Shaun Jackman <address@hidden> wrote:
>> The following patch adds a third output argument, mu for compatibility with
>> Matlab. I made an effort to update the documentation, but I'm not familiar
>> with Octave's documentation system.
>>
> 
> There is wpolifit in octave-forge that has this and more. And I still
> do not understand
> why it is not in the main octave tree yet...


Because there aren't that many of us who are porting the octave-forge
functions to Octave. I did a bit of this but searched for candidates
based on the function name clashes, and as wpolyfit isn't polyfit I
didn't identify this as a replacement.. I'm sure if you go over wpolyfit
 doing the following

* Add GPL copyright (but keep Paul's public domain copyright)
* Change '' quoted strings to "" quoted strings
* Use parenthesis in if statements
* Write "length (varargin)" and not "length(varargin)" etc
* Other standard Octave style fixes

then John would accept this as a replacement if its clearly better.

D.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]