Re: 3.0.2 release (reports on cygwin)

[Jaroslav Hajek]

On Fri, Aug 8, 2008 at 9:29 AM, Tatsuro MATSUOKA <address@hidden> wrote:
> Hello
>
> I have tested on cygwin.
> Build process went well.
>
> For make check, three errors detected.
> *****************
> Integrated test scripts:
> 1:  src/DLD-FUNCTIONS/rand.cc .............................. PASS   56/57   
> FAIL 1
> 2:  scripts/strings/strtok.m ............................... PASS   25/26   
> FAIL 1
>
> Fixed test scripts:
> 3:  test_system.m .......................................... PASS  125/126  
> FAIL 1
>
> No.1 is already solved by David but it was ignored for a long time.
> So I re-sumit the patch in the form of hg diff.
>
> No.3 can be ignored.
>
> So No.2 is a new problem, I do not have a any good idea to solve this at the 
> moment
>
> Regards
>
> Tatsuro
>
> **********************
> 1.  src/DLD-FUNCTIONS/rand.cc .............................. PASS   56/57   
> FAIL 1
> ************************
>>>>>> processing /home/octaves/hg-3.0.x/release-3-0-x/src/DLD-FUNCTIONS/rand.cc
>  ***** test
>  % Test fixed state
>  randp("seed",1);
>  assert(randp(1e9,1,6),[1000006208 1000012224 999981120 999963520 999963072 
> 999981440])
> !!!!! test failed
> error: assert (randp (1e9, 1, 6),[1000006208, 1000012224, 999981120, 
> 999963520, 999963072, 999981440])
> expected
>   1.0000e+09   1.0000e+09   9.9998e+08   9.9996e+08   9.9996e+08   9.9998e+08
> but got
>   1.0000e+09   1.0000e+09   9.9998e+08   9.9996e+08   9.9996e+08   9.9998e+08
> values do not match
> shared variables {
>  __random_statistical_tests__ = 0
> }
> This error is to be fixed.  The patch was already proposed by David on 27 Dec 
> 2007!!!!.
> http://www.nabble.com/fntest.m-results-in-test-directry-on-cygwin-octave-%3A-check-rand.cc-to14506619.html#a14510790
>
> I will re-submit the patch as change set.
>
> ************************
> diff -r 543c8d80e42a ChangeLog
> --- a/ChangeLog Mon Aug 04 22:32:47 2008 -0400
> +++ b/ChangeLog Fri Aug 08 16:11:07 2008 +0900
> @@ -1,3 +1,7 @@
> +2008-08-08  David Bateman  <address@hidden> & Tatsuro MATSUOKA  
> <address@hidden>
> +
> +       *A patch fntests for rand.cc for octave for windows (cygwin, mingw 
> ,msvc)
> +
>  2008-08-04  John W. Eaton  <address@hidden>
>
>        * Makeconf.in (do-subst-script-vals): Also substitute SED.
> diff -r 543c8d80e42a src/DLD-FUNCTIONS/rand.cc
> --- a/src/DLD-FUNCTIONS/rand.cc Mon Aug 04 22:32:47 2008 -0400
> +++ b/src/DLD-FUNCTIONS/rand.cc Fri Aug 08 16:11:07 2008 +0900
> @@ -950,7 +950,7 @@
>  %!test
>  %! % Test fixed state
>  %! randp("seed",1);
> -%! assert(randp(1e9,1,6),[1000006208 1000012224 999981120 999963520 
> 999963072 999981440])
> +%! assert(randp(1e9,1,6),[1000006208 1000012224 999981120 999963520 
> 999963072 999981440]],1e-6))
>  %!test
>  %! if (__random_statistical_tests__)
>  %!   % statistical tests may fail occasionally.
>

Moved the ChangeLog entry to src/ChangeLog and applied to 3.0.x. Thanks.


>
> ***********************
> 2:  scripts/strings/strtok.m ............................... PASS   25/26   
> FAIL 1
> *************************
>>>>>> processing /home/octaves/hg-3.0.x/release-3-0-x/scripts/strings/strcat.m
>  ***** xtest
>  assert(all (strcmp (strcat ("a", {"bc", "de"}, "f"), {"abcf", "adef"})))
> !!!!! known failure
> error: strcat: concatenating cell arrays of strings not implemented
>>>>>> processing /home/octaves/hg-3.0.x/release-3-0-x/scripts/strings/strtok.m
>  ***** test
>  for ch = "\t\n\v\f\r"
>   [t, r] = strtok (cstrcat ("beg", ch, "end"));
>   assert (t, "beg");
>   assert (r, cstrcat (ch, "end"))
>  endfor
> !!!!! test failed
> error: `cstrcat' undefined near line 231 column 22
>

Since cstrcat corresponds to strcat in 3.0.x, the fix is obvious. Done.


> **************
> 3:  test_system.m .......................................... PASS  125/126  
> FAIL 1
> ***************
>
>  test_system.m .......................................... PASS  125/126  FAIL 
> 1
> This error is to be ignored. Please see

OK. The changes are in the 3.0.x public archive.

Thanks,

-- 
RNDr. Jaroslav Hajek
computing expert
Aeronautical Research and Test Institute (VZLU)
Prague, Czech Republic
url: www.highegg.matfyz.cz