octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 3.0.4 RC1 (mingw report)


From: Tatsuro MATSUOKA
Subject: Re: 3.0.4 RC1 (mingw report)
Date: Sat, 17 Jan 2009 13:18:48 +0900 (JST)

Hello

I have built octave-3.0.4RC1 on mingw by gcc-3.4.5.
(My original build. It is not the same as bejamin:)

The build was successful.

However, errors on fileparts should be fixed for octave native to windows. 

Regards

Tatsuro

***************************************
Integrated test scripts:

1  c:\usr\Tatsu\mingwhome\octaves\octave-3.0.4RC1\src/DLD-FUNCTIONS\rand.cc  
PASS   56/57   FAIL 1
2  c:\usr\Tatsu\mingwhome\octaves\octave-3.0.4RC1\src\ov-fcn-handle.cc  PASS    
2/3    FAIL 1
3  
c:\usr\Tatsu\mingwhome\octaves\octave-3.0.4RC1\scripts/miscellaneous\fileparts.m
  PASS    3/9   
FAIL 6

Fixed test scripts:

4  test_string.m .......................................... PASS  130/131  FAIL 
1

Summary:

  PASS   4051
  FAIL      9

There were 2 expected failures (see fntests.log for details).

Expected failures are known bugs. Please help improve
Octave by contributing fixes for them.

There were 11 skipped tests (see fntest.log for details).
Skipped tests are features that are disabled in this version
of Octave as the needed libraries were not present when Octave
was built

1493 (of 1669) files have no tests.  Please help improve Octave by
contributing tests for these files (see the list in the file fntests.log).
***************

Note:
In my build, test_io.m has seemed to fall into an inifinte loop (this time 
also) so that it has been
skipped.

****
 1
****
c:\usr\Tatsu\mingwhome\octaves\octave-3.0.4RC1\src/DLD-FUNCTIONS\rand.cc  PASS  
 56/57   FAIL 1

 randp("seed",1);
 assert(randp(1e9,1,6),[1000006208 1000012224 999981120 999963520 999963072 
999981440],1e-6)
!!!!! test failed
error: assert (randp (1e9, 1, 6),[1000006208, 1000012224, 999981120, 999963520, 
999963072,
999981440],1e-6) expected
  1.0000e+009  1.0000e+009  9.9998e+008  9.9996e+008  9.9996e+008  9.9998e+008
but got
  1.0000e+009  1.0000e+009  9.9998e+008  9.9996e+008  9.9996e+008  9.9998e+008
maximum absolute error 27 exceeds tolerance 1e-006

!!!!!!!!!!!
To use relative tolerance , the third argument is give as minus value : -1e-6:

So please apply

--- a/src/DLD-FUNCTIONS/rand.cc Fri Jun 16 15:46:22 2009 -0400 
+++ b/src/DLD-FUNCTIONS/rand.cc Sat Jun 17 12:47:07 2009 +0900 
@@ -950,7 +950,7 @@ 
 %!test 
 %! % Test fixed state 
 %! randp("seed",1); 
-%! assert(randp(1e9,1,6),[1000006208 1000012224 999981120 999963520 999963072 
999981440],1e-6) 
+%! assert(randp(1e9,1,6),[1000006208 1000012224 999981120 999963520 999963072 
999981440],-1e-6) 
 %!test 
 %! if (__random_statistical_tests__) 
 %!   % statistical tests may fail occasionally.


****
 2
****
2  c:\usr\Tatsu\mingwhome\octaves\octave-3.0.4RC1\src\ov-fcn-handle.cc  PASS    
2/3    FAIL 1
This has been reported by Benjamin but no good solution seems to be found yet.

 a = 2;
 f = @(x) a + x;
 g = @(x) 2 * x;
 h = @log2;
 f2 = f;
 g2 = g;
 h2 = h;
 nm = tmpnam();
 unwind_protect
   save ("-text", nm, "f2", "g2", "h2");
   clear f2 g2 h2
   load (nm);
   assert (f(2),f2(2));
   assert (g(2),g2(2));
   assert (g(3),g2(3));
   unlink (nm);
   save ("-text", nm, "f2", "g2", "h2");
 unwind_protect_cleanup
   unlink (nm);
 end_unwind_protect
!!!!! test failed
error: function handle points to non-existent function

****
 3
****
  
c:\usr\Tatsu\mingwhome\octaves\octave-3.0.4RC1\scripts/miscellaneous\fileparts.m
  PASS    3/9   
FAIL 6
 [d, n, e] = fileparts ("/file.ext");
 assert (strcmp (d, "/") && strcmp (n, "file") && strcmp (e, ".ext"));
!!!!! test failed
error: assert (strcmp (d, "/") && strcmp (n, "file") && strcmp (e, ".ext")) 
failed
  ***** test
 [d, n, e] = fileparts ("dir/file.ext");
 assert (strcmp (d, "dir") && strcmp (n, "file") && strcmp (e, ".ext"));
!!!!! test failed
error: assert (strcmp (d, "dir") && strcmp (n, "file") && strcmp (e, ".ext")) 
failed
  ***** test
 [d, n, e] = fileparts ("./file.ext");
 assert (strcmp (d, ".") && strcmp (n, "file") && strcmp (e, ".ext"));
!!!!! test failed
error: assert (strcmp (d, ".") && strcmp (n, "file") && strcmp (e, ".ext")) 
failed
  ***** test
 [d, n, e] = fileparts ("d1/d2/file.ext");
 assert (strcmp (d, "d1/d2") && strcmp (n, "file") && strcmp (e, ".ext"));
!!!!! test failed
error: assert (strcmp (d, "d1/d2") && strcmp (n, "file") && strcmp (e, ".ext")) 
failed
  ***** test
 [d, n, e] = fileparts ("/d1/d2/file.ext");
 assert (strcmp (d, "/d1/d2") && strcmp (n, "file") && strcmp (e, ".ext"));
!!!!! test failed
error: assert (strcmp (d, "/d1/d2") && strcmp (n, "file") && strcmp (e, 
".ext")) failed
  ***** test
 [d, n, e] = fileparts ("/.ext");
 assert (strcmp (d, "/") && strcmp (n, char (zeros (1, 0))) && strcmp (e, 
".ext"));
!!!!! test failed
error: assert (strcmp (d, "/") && strcmp (n, char (zeros (1, 0))) && strcmp (e, 
".ext")) failed

*************************
The above seems to be filesep() is '\' but not '/' in windows.

octave.exe:11> [d, n, e] = fileparts ("\\file.ext")
d = \
n = file
e = .ext
octave.exe:12> filesep
ans = \

****
 4
****
For No.4, I think that I have already sent


--- a/ChangeLog Tue Aug 19 16:15:52 2008 -0400 
+++ b/ChangeLog Fri Aug 22 13:37:16 2008 +0900 
@@ -1,3 +1,7 @@ 
+2008-08-22  Tatsuro MATSUOKA  <address@hidden> 
+ 
+       test/octave.test/string/isprint-1.m in test_string.m for fixed. 
+ 
 2008-08-19  Jaroslav Hajek <address@hidden> 
  
        Version 3.0.2 released. 
diff -r 4908e39553b0 test/test_string.m 
--- a/test/test_string.m        Tue Aug 19 16:15:52 2008 -0400 
+++ b/test/test_string.m        Fri Aug 22 13:37:16 2008 +0900 
@@ -532,7 +532,7 @@ 
 %! result = zeros (1, 128); 
 %! 
 %! result (33:127) = 1; 
-%! if (ispc () && ! isunix ()) 
+%! if (size(findstr (octave_config_info('canonical_host_type'), 'msvc'),2)) 
 %!   result(10) = 1; 
 %! endif 
 %!



--------------------------------------
Power up the Internet with Yahoo! Toolbar.
http://pr.mail.yahoo.co.jp/toolbar/


reply via email to

[Prev in Thread] Current Thread [Next in Thread]