octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Yet another OOP update


From: Robert T. Short
Subject: Re: Yet another OOP update
Date: Sat, 09 May 2009 16:07:14 -0700
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.21) Gecko/20090402 SeaMonkey/1.1.16

Glad to.

John W. Eaton wrote:
On  8-May-2009, Robert T. Short wrote:

| Attached is a patch that will fix object load to call the class | constructor. I also fixed the load_ascii function and fixed "struct" to | return the underlying struct when the argument is an object. | | I tested this on some fairly complex objects and it seems to work for | -text, -hdf5 and -v6 files. I don't like the way it fails when there | are errors (e.g. a constructor with arguments) and will make it nicer, | but this works quite nicely.

I checked in this changeset.

Could you also look at the code in src/ls-mat5.cc that loads objects
from MAT files and make similar changes there?  Also, since the
structure of the code that loads MAT files is different, you can
easily convert an object to a struct if there is a problem with the
exemplar or the call to the constructor fails.

Thanks,

jwe





reply via email to

[Prev in Thread] Current Thread [Next in Thread]