[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: function definitions in tests
From: |
Jaroslav Hajek |
Subject: |
Re: function definitions in tests |
Date: |
Tue, 19 Jan 2010 07:26:16 +0100 |
On Tue, Jan 19, 2010 at 6:43 AM, John W. Eaton <address@hidden> wrote:
> On 19-Jan-2010, Jaroslav Hajek wrote:
>
> | I have just a nitpick:
> | If you add an entry "undo previous change" to ChangeLog, I think you
> | shouldn't delete the entry for the previous change. The result is very
> | confusing, because it's unclear what "previous change" refers to.
>
> In this case, I thought "previous change" clearly meant the
> previous change to the same file, and there is still an entry for
> that, just below my entry. I didn't delete it, I just changed the
> description of what had changed from
>
> * testfun/test.m: Fix !function test blocks.
>
> to
>
> * testfun/test.m: Append endfunction to function test blocks.
>
> jwe
>
Aha, sorry, I misread the diff. I thought there were two entries and
you deleted one. No problem then.
--
RNDr. Jaroslav Hajek, PhD
computing expert & GNU Octave developer
Aeronautical Research and Test Institute (VZLU)
Prague, Czech Republic
url: www.highegg.matfyz.cz