octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: safer way to use gnulib


From: Ben Abbott
Subject: Re: safer way to use gnulib
Date: Tue, 16 Mar 2010 14:44:43 -0400

On Tuesday, March 16, 2010, at 02:13PM, "John W. Eaton" <address@hidden> wrote:
>On 16-Mar-2010, Ben Abbott wrote:
>
>| Better, but ...
>| 
>| $ g++-4.2 -save-temps -DHAVE_CONFIG_H -I. -I.. -I/sw/lib/flex/include 
>-I/sw/include -O0 -g -m32 -I/sw/include/freetype2 -I/sw/include/qhull 
>-I/usr/include -I../libgnu -I../libgnu -I../libcruft/misc -I../liboctave 
>-I../liboctave -I. -I. -I/sw/lib/flex/include -I/sw/include -O0 -g -m32 
>-I/sw/include/freetype2 -I/sw/include/qhull -I/usr/include -I/sw/include -O0 
>-g -m32 -D_THREAD_SAFE -D_REENTRANT -DHAVE_CONFIG_H -mieee-fp -I/sw/include 
>-I/sw/include/freetype2 -I/sw/include -I/usr/X11/include -Wall -W -Wshadow 
>-Wold-style-cast -Wformat -I/sw/include -O0 -g -m32 -D_THREAD_SAFE 
>-D_REENTRANT -D_THREAD_SAFE -pthread -I/sw/include -O0 -g -m32 -D_THREAD_SAFE 
>-D_REENTRANT -MT liboctinterp_la-sighandlers.lo -MD -MP -MF 
>.deps/liboctinterp_la-sighandlers.Tpo -c sighandlers.cc  -fno-common -DPIC -o 
>.libs/liboctinterp_la-sighandlers.o
>| sighandlers.cc: In function ‘void my_friendly_exit(const char*, int, bool)’:
>| sighandlers.cc:132: warning: use of old-style cast
>| sighandlers.cc:158: warning: use of old-style cast
>| sighandlers.cc: In function ‘void sigchld_handler(int)’:
>| sighandlers.cc:233: error: expected unqualified-id before ‘(’ token
>| bens-macbook:src bpabbott$  ‘octave_interrupt_handler 
>octave_ignore_interrupts()’:
>| sighandlers.cc:507: warning: use of old-style cast
>| sighandlers.cc: In function ‘void install_signal_handlers()’:
>| sighandlers.cc:647: warning: use of old-style cast
>| bens-macbook:src bpabbott$ vi sighandlers.cc 
>
>We have the same problem with sigaddset, which is used in the
>BLOCK_SIGNAL macro.  So try undefining sigaddset just before any uses
>of the BLOCK_SIGNAL macro.  Does that help?  I've posted a message
>about this problem to the gnulib bug list.
>
>jwe
>

I added the "undef sigaddset" to one line ...

233 #undef sigaddset
234   BLOCK_CHILD (set, oset);
235 
236   if (octave_child_list::wait ())
237     {
238       // The status of some child changed.
239 
240       octave_signal_caught = 1;
241 
242       octave_signals_caught[SIGCHLD] = true;
243     }
244 
245   octave_set_interrupt_handler (saved_interrupt_handler);
246 
247   UNBLOCK_CHILD (oset);

I now get warnings, but the build continues.

g++-4.2 -DHAVE_CONFIG_H -I. -I.. -I/sw/lib/flex/include -I/sw/include -O0 -g 
-m32 -I/sw/include/freetype2 -I/sw/include/qhull -I/usr/include -I../libgnu 
-I../libgnu -I../libcruft/misc -I../liboctave -I../liboctave -I. -I. 
-I/sw/lib/flex/include -I/sw/include -O0 -g -m32 -I/sw/include/freetype2 
-I/sw/include/qhull -I/usr/include -I/sw/include -O0 -g -m32 -D_THREAD_SAFE 
-D_REENTRANT -DHAVE_CONFIG_H -mieee-fp -I/sw/include -I/sw/include/freetype2 
-I/sw/include -I/usr/X11/include -Wall -W -Wshadow -Wold-style-cast -Wformat 
-I/sw/include -O0 -g -m32 -D_THREAD_SAFE -D_REENTRANT -D_THREAD_SAFE -pthread 
-I/sw/include -O0 -g -m32 -D_THREAD_SAFE -D_REENTRANT -MT 
liboctinterp_la-sighandlers.lo -MD -MP -MF 
.deps/liboctinterp_la-sighandlers.Tpo -c sighandlers.cc  -fno-common -DPIC -o 
.libs/liboctinterp_la-sighandlers.o
sighandlers.cc: In function ‘void my_friendly_exit(const char*, int, bool)’:
sighandlers.cc:132: warning: use of old-style cast
sighandlers.cc:158: warning: use of old-style cast
sighandlers.cc: In function ‘octave_interrupt_handler 
octave_ignore_interrupts()’:
sighandlers.cc:508: warning: use of old-style cast
sighandlers.cc: In function ‘void install_signal_handlers()’:
sighandlers.cc:648: warning: use of old-style cast

Ben








reply via email to

[Prev in Thread] Current Thread [Next in Thread]