[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Patch for adding features in Settings GUI
From: |
Jordi Gutiérrez Hermoso |
Subject: |
Re: Patch for adding features in Settings GUI |
Date: |
Fri, 16 Mar 2012 12:47:05 -0400 |
On 16 March 2012 10:49, Atul jangra <address@hidden> wrote:
> Hey maintainers attached is a patch for adding a functionality to the
> SettingDialog in the GUI of Octave.
A couple of comments.
Please don't disable code by commenting it out. Just delete it. The hg
history will show the original code if we want to look at it. Having
commented-out code clutters reading the source.
Also please provide a commit message. You can look at some examples in
the hg history:
http://hg.savannah.gnu.org/hgweb/octave/
We haven't clearly spelled out the guidelines for writing a commit
message anywhere, but they're roughly adapted from the GNU coding
standards:
http://www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html
- Jordi G. H.
- Patch for adding features in Settings GUI, Atul jangra, 2012/03/16
- Re: Patch for adding features in Settings GUI,
Jordi Gutiérrez Hermoso <=
- Re: Patch for adding features in Settings GUI, John W. Eaton, 2012/03/16
- Re: Patch for adding features in Settings GUI, Atul jangra, 2012/03/16
- Re: Patch for adding features in Settings GUI, Jordi Gutiérrez Hermoso, 2012/03/16
- Re: Patch for adding features in Settings GUI, Atul jangra, 2012/03/16
- Re: Patch for adding features in Settings GUI, Jacob Dawid, 2012/03/16
- Re: Patch for adding features in Settings GUI, Jordi Gutiérrez Hermoso, 2012/03/23
- Re: Patch for adding features in Settings GUI, Atul jangra, 2012/03/23