Re: build without gnuplot

[Mike Miller]

On Wed, Apr 25, 2012 at 9:40 AM, Ben Abbott <address@hidden> wrote:
> On Apr 24, 2012, at 8:34 PM, Mike Miller wrote:
>
>> On Tue, Apr 24, 2012 at 04:16:36PM -0400, Ben Abbott wrote:
>>
>>> I tried ...
>>>
>>> $ hg diff
>>> diff --git a/configure.ac b/configure.ac
>>> --- a/configure.ac
>>> +++ b/configure.ac
>>> @@ -2483,6 +2483,9 @@
>>>     AC_MSG_WARN([installed, but you won't be able to use any of Octave's])
>>>     AC_MSG_WARN([plotting commands without it.])
>>>   fi
>>> +  DOCDIR=
>>> +  AC_MSG_WARN([])
>>> +  AC_MSG_WARN([Building the documentation has been disabled.])
>>>   AC_MSG_WARN([])
>>>   AC_MSG_WARN([If gnuplot is installed, but isn't in your path, you can])
>>>   AC_MSG_WARN([tell Octave where to find it by using the gnuplot_binary])
>>>
>>> And my build ended with ...
>>> [...]
>>>
>>> It appears "make" is still trying to build the docs.
>>
>> Ok, finally at my dev box, attached works for me, let me know if it
>> works for you.  The change to the doc variable and conditional has to be
>> done before AC_OUTPUT so it can't go with the warning sections at the
>> very end of the script.  I put it near OCTAVE_PROG_GNUPLOT for locality.
>>
>> --
>> mike
>> <octave-4dc85c4f151b.patch>
>
> Using a clean archive, I build with and without gnuplot. Everything worked as 
> intended.
>
> I'll try a build with "--disable-docs" next.
>
> Are there any other cases that should be checked before pushing this 
> changeset ?

That's about it.  You should see different warning messages for
"--disable-docs" vs. not having gnuplot.  You could do "--enable-docs"
to be thorough but that should be same as default :)

-- 
mike