Re: MinGW build error (2): error: variable 'QTextStream in' has initializer but incomplete type etc

[Michael Goffioul]

On Sun, Aug 26, 2012 at 8:56 PM, Philip Nienhuis <address@hidden> wrote:

Philip Nienhuis wrote
>
>
> Michael Goffioul wrote
>>
>> :
>> <snip>
>> :
>> You cant' achieve that without modifying the Makefile.am in gui/src/ to
>> add
>> the flags to the libqterminal target. But that would also require to link
>> that with some tests in configure as it is not needed on all platforms.
>>
>> Michael.
>>
>
> I manually added -DUNICODE to "libqterminal_la_CPPFLAGS" in .\libgui\src
> and indeed the build continues. So at least for MinGW configure tests are
> probably warranted.
>
> But the build breaks again, a bit further down:
>
> :
> libtool: compile:  g++ -shared-libgcc -DHAVE_CONFIG_H -I.
> -I../../../octave/libgui/src -I../..
> -IX:/programs/msys/home/Philip/qt4/qt-everywhere-opensource-src-4.7.4/include
> -IX:/programs/msys/home/Philip/qt4/qt-everywhere-opensource-src-4.7.4/include/QtCore
> -IX:/programs/msys/home/Philip/qt4/qt-everywhere-opensource-src-4.7.4/include/QtGui
> -I../../../octave/libgui/src/../qterminal/libqterminal -DUNICODE
> -I/x/Programs/gplibs/include -I/x/Programs/OctaveLibs/include
> -I/x/programs/GnuWin32/include -g -O2 -mieee-fp
> -Ic:/Programs/gplibs/include/freetype2 -Ic:/Programs/gplibs/include
> -IX:/Programs/gplibs/include -Wall -W -Wshadow -Wold-style-cast -Wformat
> -Wpointer-arith -Wwrite-strings -Wcast-align -Wcast-qual -g -O2 -MT
> libqterminal_la-moc-QTerminal.lo -MD -MP -MF
> .deps/libqterminal_la-moc-QTerminal.Tpo -c
> ../qterminal/libqterminal/moc-QTerminal.cc  -DDLL_EXPORT -DPIC -o
> .libs/libqterminal_la-moc-QTerminal.o
>             <snip>
> ../qterminal/libqterminal/moc-QTerminal.cc: At global scope:
> ../qterminal/libqterminal/moc-QTerminal.cc:41:8: error:
> 'QUnixTerminalImpl' has not been declared
> :
>

Digging around a bit, I see that in QTerminal.h the "#ifdef Q_OS_WIN32"
doesn't work; a moc-QTerminal.cc is generated w QUnixTerminalImpl.
Manually commenting out the unix section indeed induces a properly generated
moc-QTerminal.cc w QWinTerminalImpl.

Upon that fix, the build continues until it bails out in file-editor-tab.cc
complaining about undeclared QFileDialog type or -class.
Adding
#include "qfiledialog.h"
in file-editor-tab.cc lets the build continue until

:
../../../octave/libgui/src/m-editor/file-editor-tab.cc: In member function
'void file_editor_tab::load_file(QString)':
../../../octave/libgui/src/m-editor/file-editor-tab.cc:639:18: error:
variable 'QTextStream in' has initializer but incomplete type
../../../octave/libgui/src/m-editor/file-editor-tab.cc:640:3: error:
incomplete type 'QApplication' used in nested name specifier
../../../octave/libgui/src/m-editor/file-editor-tab.cc:642:3: error:
incomplete type 'QApplication' used in nested name specifier
../../../octave/libgui/src/m-editor/file-editor-tab.cc: In member function
'bool file_editor_tab::save_file(QString)':
../../../octave/libgui/src/m-editor/file-editor-tab.cc:696:19: error:
variable 'QTextStream out' has initializer but incomplete type
../../../octave/libgui/src/m-editor/file-editor-tab.cc:697:3: error:
incomplete type 'QApplication' used in nested name specifier
../../../octave/libgui/src/m-editor/file-editor-tab.cc:699:3: error:
incomplete type 'QApplication' used in nested name specifier

There I gave up.
Of course I could try to find out what other #includes are needed but I
suspect I get swamped further on.
I think some more developer time for MinGW is warranted. I'm prepared to
assist, but this is all above my head.

I'll look into it.

Michael.