Re: changes to graphics.cc and subplot.m

[Ben Abbott]

On Jul 20, 2013, at 5:48 AM, Stefan Mahr wrote:

All,

I've just pushed two changesets ...

http://hg.savannah.gnu.org/hgweb/octave/rev/350cad34b0f8

http://hg.savannah.gnu.org/hgweb/octave/rev/942d892524b3

... which should fix several bugs in the tracker (I'll verify and close them on the next week).  I don't expect any regressions, but if anyone sees something unexpected please let me know.

I have some additional changes planned to clean up legend.m.

Ben

I found some issues:

------------------

subplot() can't be called twice with gnuplot frontend.

octave-cli:1> subplot(1,1,1)
octave-cli:2> subplot(1,1,1)
error: 'tmp' undefined near line 236 column 31
error: evaluating argument list element number 3
error: called from:
error:   /usr/share/octave/3.7.5/m/plot/subplot.m at line 236, column 7
octave-cli:2>

I think you just forgot to change line 236 in subplot.m

- set (cf, "currentaxes", tmp);
+ set (cf, "currentaxes", hsubplot);

Ok.  I'll push a change in your name

------------------------

The behaviour of subplot with fltk frontend looks strange. Also, the
first fltk plot differs from the second.

1) gnuplot
graphics_toolkit gnuplot
subplot(2,1,1); plot(rand(10,1)); subplot(2,1,2); plot(rand(10,1))

2) fltk
graphics_toolkit fltk
subplot(2,1,1); plot(rand(10,1)); subplot(2,1,2); plot(rand(10,1))

3) fltk
graphics_toolkit fltk
subplot(2,1,1); plot(rand(10,1)); subplot(2,1,2); plot(rand(10,1))
subplot(2,1,1); plot(rand(10,1)); subplot(2,1,2); plot(rand(10,1))

See attached the screenshot of gnuplot, fltk and fltk second plot. (from
left to right)

If I use additional figure command before subplot, everything looks ok.
graphics_toolkit fltk
figure(1)
subplot(2,1,1); plot(rand(10,1)); subplot(2,1,2); plot(rand(10,1))
subplot(2,1,1); plot(rand(10,1)); subplot(2,1,2); plot(rand(10,1))

I'm not seeing a problem.

graphics_toolkit fltk

close all
subplot(2,1,1); plot(rand(10,1)); subplot(2,1,2); plot(rand(10,1))

Then if I repeat the plot ...

subplot(2,1,1); plot(rand(10,1)); subplot(2,1,2); plot(rand(10,1))

Can you reproduce the problem when you begin with "close all"?

Ben