octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: LLVM m4 macros


From: Max Brister
Subject: Re: LLVM m4 macros
Date: Mon, 22 Jul 2013 21:59:24 -0700

> Hello Rik,

> 2013/7/22 Rik <address@hidden>

> > 7/21/13
> >
> > LYH,
> >
> > I noticed that in your most recent changeset you used AC_MSG_ERROR("...").
> > The quote character for m4 is '[' and ']' so I changed that in in this
> > changeset (http://hg.savannah.gnu.org/hgweb/octave/rev/8d84dc5f5b5d).
> > Programming in m4 is a pain in the ass...
> >
>
> That's fine. Programming in m4 is new to me. Thanks for your correction.

Oops, I should have caught this when reviewing the patch, thanks Rik.

<snip>
> I could disable JIT when I detect neither llvm/DataLayout.h nor llvm/Target/TargetData.h exist, rather than= stop the configuration. How do you think?

I'm currently working on updating these checks to support LLVM 3.3 (so LYH can focus on improving JIT). I'm rewriting these checks to use AC_CHECK_HEADERS at jwe's suggestion.

--
Max Brister

reply via email to

[Prev in Thread] Current Thread [Next in Thread]