octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: octave-image regionprops: Addition of labeled region in image I


From: Carnë Draug
Subject: Re: octave-image regionprops: Addition of labeled region in image I
Date: Fri, 13 Sep 2013 02:50:18 +0100

On 12 September 2013 20:32, Andreas Weber <address@hidden> wrote:
> Dear maintainers,
> I've added the parameter "I" for PixelValueMeasurements
> MaxIntensity, MinIntensity, MeanIntensity, PixelValues, WeightedCentroid
> and made some cleanup of double code, for example
> case {"boundingbox", "bounding_box"}
> is unneeded because _ are removed with property = lower
> (strrep(properties{k}, "_", ""));
>
> Can I push the change?

I didn't try to apply the patch and see if it still works but looks
good. Just one note, why didn't you remove the "euler_number" option
like you did to all the other ones with an underscore? Other than
that, I'd say go on push it.

Carnë


reply via email to

[Prev in Thread] Current Thread [Next in Thread]