octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: make check is now opening a figure window


From: Rik
Subject: Re: make check is now opening a figure window
Date: Fri, 03 Jan 2014 09:18:49 -0800

On 01/03/2014 04:13 AM, address@hidden wrote:
> Message: 1
> Date: Fri, 3 Jan 2014 09:44:39 +0100
> From: Kai Torben Ohlhus <address@hidden>
> To: "John W. Eaton" <address@hidden>
> Cc: octave maintainers mailing list <address@hidden>
> Subject: Re: make check is now opening a figure window
> Message-ID:
>       <address@hidden>
> Content-Type: text/plain; charset="utf-8"
>
> On Fri, Jan 3, 2014 at 5:07 AM, John W. Eaton <address@hidden> wrote:
>
>> > I recently noticed that running make check on the default branch is
>> > opening a figure window.  Before I try to track this down, does someone
>> > know which test it is or what changeset caused this behavior?  If we
>> > absolutely must open a figure window during the make check process, we
>> > should also close it at the end of the test that opens it, or at least
>> > after the set of tests that need it.
>> >
>> > Thanks,
>> >
>> > jwe
>> >
>> >
> I have this behavior too. It seems to be changeset 18193 (31d8e19a745d)
> voronoi.m: Add input validation test for 2 points (bug #40996)
>
> This opens a figure window as well:
>
> octave:1> test voronoi
> PASSES 8 out of 8 tests
>
> Best,
>
> Kai
The tests at least showed that the function was not doing input validation
correctly.  I changed voronoi.m so that it won't pop open a new figure
window when input validation fails
(http://hg.savannah.gnu.org/hgweb/octave/rev/0ecd4618b1fc)

--Rik



reply via email to

[Prev in Thread] Current Thread [Next in Thread]