Re: demos which uses patch/legend fails after cset df972b9d080a

[Andreas Weber]

Am 21.07.2014 22:55, schrieb Pantxo Diribarne:
> Le 21/07/2014 22:18, Andreas Weber a écrit :
>> Dear Pantxo, since changeset
>>
>> Änderung:        18901:df972b9d080a
>> Nutzer:          Pantxo Diribarne <address@hidden>
>> Datum:           Sat Jun 21 13:07:57 2014 +0200
>> Zusammenfassung: Translate patch property listeners to C++ (bug #42159)
>>
>> these demos fails with A(I,J): row index out of bounds; value 2 out of
>> bound 1 or A(I,J): column index out of bounds; value 3 out of bound 2
>>
>> area 1
>> copyobj 2
>> legend 18
>> legend 19
>> legend 35
>> pie3 1
>> pie3 2
>> pie3 3
>> ribbon 1

> Dear  Andy,
> 
> Strange, none of those demos fail for me with qt, fltk or gnuplot. I
> have actually used demos to compare the figures after the cset with
> those in [1]. Does the failure occur in graphics.cc, in __patch__.m or
> elsewhere?
> 
> I am currently at "hg summary":
> parent: 18943:714ce8ca71ea tip

Hi Pantxo,
I have to admit that I've misread the date from df972b9d080a and thought
the change is from today (not 4 weeks ago). A hg bisect script
identified df972b9d080a but I guess my workspace just was messy.

> [1] http://tech-chat.de/compare_plot_demos/

Yeah, I made these plots ;-)

Sorry for the noise, I'll make a fresh build tomorrow.

-- Andy

PS: just for the records a debug session for "demo area":
octave:1> debug_on_error(1)
octave:2> t = linspace (0, 2*pi, 100)';
octave:3> y = [sin(t).^2, cos(t).^2];
octave:4> area (t, y);
octave:5> axis tight
octave:6> legend ('sin^2', 'cos^2', 'location', 'NorthEastOutside');
error: __go_patch__: A(I,J): row index out of bounds; value 2 out of bound 1
error: called from
    __patch__ at line 188 column 7
    patch at line 87 column 16
    legend at line 885 column 20
stopped in
/home/andy/src/octave-default-dbg-build/../octave-src/scripts/plot/draw/private/__patch__.m
at line 188
188:     h = __go_patch__ (p, args{:});
debug> dblist
183       else
184         args = varargin;
185       endif
186     
187       if (!failed)
188-->      h = __go_patch__ (p, args{:});
189       endif
190     endfunction
debug> args
args =
{
  [1,1] = xdata
  [1,2] =

     0.054498   0.463236   0.463236   0.054498

  [1,3] = ydata
  [1,4] =

     0.90000   0.90000   0.60000   0.60000

  [1,5] = facecolor
  [1,6] =

     0   0   1

  [1,7] = edgecolor
  [1,8] =

     0   0   0

  [1,9] = cdata
  [1,10] = [](0x0)
  [1,11] = userdata
  [1,12] = -18.942
}