|Subject:||Re: Location for ilu code|
|Date:||Sat, 16 Aug 2014 17:15:48 +0100|
On 08/15/2014 05:01 PM, address@hidden wrote:
Subject:Where to place and how to organize my GSOC work. From:Eduardo <address@hidden> Date:08/15/2014 12:00 PM
To:Octave Maintainers List <address@hidden>, Kai Torben Ohlhus <address@hidden>
List-Post:<mailto:address@hidden> Precedence:list MIME-Version:1.0 Message-ID:<address@hidden> Content-Type:multipart/alternative; boundary=047d7bd9161c3840320500afa4f2 Message:2
1) ilu.m as a wrapper for __iluc__.cc, __ilutp__.cc and __ilu0__.cc. The .m file is located inside the script/sparse directory and the dld functions inside /libinterp/dldfcn. My question is, which would the best approach here?Dear maintainers,As GSOC is finishing I want to just put together all the code in a way that can be integrated into the default branch of Octave. I have till now that scenario:
A) Keep the actual situation.
B) Maybe put together all the .cc file inside one called __ilu__.cc but keep the three dld functions inside. The rest remain the same.
C) The same as B but just having only *one* dld-function inside called __ilu_() and from it calling iluc(), ilutp() and ilu0() (which will not be dld but will be in the same file). __ilu__() will be then the function called within ilu.m as __ilu__("ilu0", ...), __ilu__("iluc", ...) and __ilu__("ilutp", ....) for each specific function.
It would be best to collect the code into a single cc file so I suggest option B or C. With only 3 functions I don't think it is polluting the global namespace to make all 3 of them visible as in option B. In any case, they will have the the '__' prefix and suffix so that they won't be used by ordinary
I have also noticed that for __foo__.cc type files there is kind of agreement of not writing tests inside them (in my case I do have). Should I move all the tests to ilu.m?
Generally that's true so I would stick to convention and put the tests in ilu.m
|[Prev in Thread]||Current Thread||[Next in Thread]|