octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Support sparse matrices in cholinsert


From: Daniel Kraft
Subject: [PATCH] Support sparse matrices in cholinsert
Date: Thu, 11 Sep 2014 14:31:01 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0

Hi!

The attached patches implement support for sparse matrices in
cholinsert.  (By using the corresponding functions in CHOLMOD.)

Are they ok?  It seems to work for me, but since this was the first time
that I worked with CHOLMOD, I may well have done something wrong.

Note that this may put Octave ahead of its "competition" -- at least
Matlab 2011b (which is the version I have access to) seems not to
support this.

If the patch is ok, I will also implement sparse matrices for cholupdate
and choldelete, for which also CHOLMOD support exists.

One question:  For each operation, the Cholesky factor has to be copied
to construct the cholmod_factor object, which is quite costly.  So I
believe that there would be a definite performance benefit if multiple
rows could be added at once.  Do you think it is a good idea to extend
cholinsert to support this (possibly only for sparse matrices)?  Or
create a new function to do this?  Unfortunately, adding multiple rows
gets a bit messy since after each addition the indices shift and also
each successively added row is one entry longer than the previous ones.
 The precise interface will have to be discussed and documented well.
I'm willing to do all that.

Yours,
Daniel

-- 
http://www.domob.eu/
OpenPGP: 901C 5216 0537 1D2A F071  5A0E 4D94 6EED 04F7 CF52
Namecoin: id/domob -> https://nameid.org/?name=domob
--
Done:  Arc-Bar-Cav-Hea-Kni-Ran-Rog-Sam-Tou-Val-Wiz
To go: Mon-Pri

Attachment: patch_1.diff
Description: Text Data

Attachment: patch_2.diff
Description: Text Data

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]