Re: Test failures associated with license.m

[Rik]

On 10/06/2014 10:10 AM, Daniel J Sebald wrote:
> On 10/05/2014 11:02 PM, Rik wrote:
>> On 10/05/2014 02:52 AM, address@hidden wrote:
>>> Subject:
>>> Test failures associated with license.m
>>> From:
>>> Daniel J Sebald <address@hidden>
>>> Date:
>>> 10/04/2014 11:41 AM
>>>
>>> To:
>>> Octave Maintainers <address@hidden>
>>>
>>> List-Post:
>>> <mailto:address@hidden>
>>> Content-Transfer-Encoding:
>>> 7bit
>>> Precedence:
>>> list
>>> MIME-Version:
>>> 1.0
>>> Message-ID:
>>> <address@hidden>
>>> Content-Type:
>>> text/plain; charset=ISO-8859-1; format=flowed
>>> Message:
>>> 1
>>>
>>>
>>> I'm seeing some test failures.  One with polygcd, which I think is a
>>> known random occurrence failure.  (Should we change it to "known
>>> failure"?)  Then there are five failures for the output of the license
>>> command:
>>>
>>>>>>>> processing
>>>>>>>> /usr/local/src/octave/octave-complex_operators/octave/scripts/miscellaneous/license.m
>>>>>>>>
>>>>>>>>
>>> ***** assert ((license ("inuse", "octave")).feature, "octave")
>>> !!!!! test failed
>>> cellfun: C must be a cell array
>>>
>>> etc.
>>>
>>
>> Dan,
>>
>> I checked in a change to license.m so that it uses 'pkg list' instead of
>> 'pkg describe all'
>> (http://hg.savannah.gnu.org/hgweb/octave/rev/672674d5e8d9).  This fixes
>> the failing tests and also greatly speeds up the function because 'pkg
>> describe all' is very slow.
>>
>> tic; test license; toc
>>
>> was 8.4 seconds and is now 0.64 seconds or ~13X improvement.
>
> Thanks Rik,
>
> octave:1> tic; test license; toc
> warning: describe: some elements in list of return values are undefined
> ***** assert ((license ("inuse", "octave")).feature, "octave")
> !!!!! test failed
> cellfun: C must be a cell array
> Elapsed time is 0.0567482 seconds.
> octave:2> tic; test license; toc
> PASSES 11 out of 11 tests
> Elapsed time is 0.16112 seconds.
>
> The test became slower!  ;)

Yeah, it's soooo much slower when you run all 11 tests rather than erroring
out after just 1 :)

--Rik