Re: 4.2.2 release

[Dmitri A. Sergatskov]

__octave_config_info__ ("hg_id")
ans = 36ca11f78553

I think a binary format would be more robust.

(Stripping meta data and using high compression would probably improves things too)

Anyway, the svg produced by dev version (on the same computer) is slightly smaller
 ls -log sombrero_dev.svg
-rw-rw-r--. 1 2980162 Feb 16 01:27 sombrero_dev.svg
ls -log sombrero_stable.svg
-rw-rw-r--. 1 3330663 Feb 16 01:26 sombrero_stable.svg

On Fri, Feb 16, 2018 at 1:17 AM, Andreas Weber <address@hidden> wrote:

Am 15.02.2018 um 19:32 schrieb Dmitri A. Sergatskov:
> make check fails on __osmesa_print__.cc-tst with size mismatch
> (I guess it was changed on dev version and not on stable?)
>
>
> ***** testif HAVE_OPENGL, HAVE_OSMESA, HAVE_GL2PS_H
>  if (isunix ())
>    hf = figure ("visible", "off");
>    fn = tempname ();
>    unwind_protect
>      sombrero ();
>      __osmesa_print__ (hf, fn, "svg");
>      assert (stat (fn).size, 2579392, -0.1);
>      img = __osmesa_print__ (hf);
>      assert (size (img), [get(hf, "position")([4, 3]), 3]);
>      ## Use pixel sum per RGB channel as fingerprint
>      img_fp = squeeze (sum (sum (img), 2));
>      assert (img_fp, [52942515; 54167797; 56158178], -0.05);
>    unwind_protect_cleanup
>      close (hf);
>      unlink (fn);
>    end_unwind_protect
>  endif
> !!!!! test failed
> ASSERT errors for:  assert (stat (fn).size,2579392,-0.1)
>
>   Location  |  Observed  |  Expected  |  Reason
>      ()        3330663      2579392      Rel err 0.29126 exceeds tol 0.1
>
> ​This is on Fedora 27, gl2ps 1.4.0.

Can you confirm, that you see a correct sombrero plot when running

hf = figure ("visible", "off");
sombrero ();
__osmesa_print__ (hf, "foo.svg", "svg");

Can you upload the resulting foo.svg and add a link?
Do you have a good idea how to check if the generated image is as
expected and which is more robust?

Thank you in advance, Andy

-----------------------------------------
Join us March 12-15 at CERN near Geneva
Switzerland for OctConf 2018.  More info:
https://wiki.octave.org/OctConf_2018
-----------------------------------------

sombrero_stable.svg.bz2
Description: BZip2 compressed data