Re: [octave forge] control: support Octave >3.0.0?

[Doug Stewart]

On Thu, Mar 8, 2018 at 10:44 AM, Olaf Till <address@hidden> wrote:

On Wed, Mar 07, 2018 at 07:27:51PM -0500, Doug Stewart wrote:
> Test on 4.2.0 all pass
> Test on stable all pass.

I get some failures with Octave release 4.2.1:

inst/bstmodred.m: %!assert (Mo, Me, 1e-4); fails due to opposite signs
in some elements of Mo vs. Me

inst/damp.m: First test fails because A is not an "lti" system. The
error message is misleading, seemingly because the input testing in
damp.m is wrong: It accepts a square matrix even if type is not "lti",
but then pole() is not found, because pole.m is only under @lti/ .

inst/ltimodels.m: 12 tests fail, this group of 6:

%!assert (ac, ac_e, 1e-4);
%!assert (ec, ec_e, 1e-4);
%!assert (bc, bc_e, 1e-4);
%!assert (cc, cc_e, 1e-4);
%!assert (q, q_e, 1e-4);
%!assert (z, z_e, 1e-4);

seemingly due to opposite signs in some elements, and this group of 6:

%!assert (ao, ao_e, 1e-4);
%!assert (eo, eo_e, 1e-4);
%!assert (bo, bo_e, 1e-4);
%!assert (co, co_e, 1e-4);
%!assert (q, q_e, 1e-4);
%!assert (z, z_e, 1e-4);

except for the 4th not due to opposite signs.

Olaf

--
public key id EAFE0591, e.g. on x-hkp://pool.sks-keyservers.net

Yes I saw those. but damp works for me on latest stable.

attached is what I see.

--

DAS

diary
Description: Binary data