RE: Windows uninstall now reboots system?

[JohnD]

> -----Original Message-----
> From: JohnD [mailto:address@hidden
> Sent: Tuesday, January 15, 2019 11:27 AM
> To: address@hidden
> Subject: RE: Windows uninstall now reboots system?
> 
> > Message: 4
> > Date: Tue, 15 Jan 2019 09:52:50 -0500
> > From: "John W. Eaton" <address@hidden>
> > To: Octave Maintainers List <address@hidden>
> > Subject: Windows uninstall now reboots system?
> > Message-ID: <address@hidden>
> > Content-Type: text/plain; charset=utf-8; format=flowed
> >
> > I've been doing some testing of the Windows binaries and have noticed
> > that the uninstaller now prompts for a reboot.  I don't recall this
> > happening previously.
> >
> > Is that a change we made, a change due to upgrading to a new version of
> > NSIS, or something Windows is doing to us?
> >
> > Is it really necessary to reboot after uninstalling Octave on Windows?
> >
> > jwe
> >
> >
> 
> 
> I see the reboot question, but never do it -and I believe it only happens
If
> you installed and havent done a reboot sometime between then and the
> uninstall.
> 
> Its occurring because the msys2 part of the install registering of the
> environment (vash --login) starts gpg-agent, and since its still running
it
> cant uninstall that file - hence the message on rebooting - I believe we
can
> disable that reboot option, however the files will still be there.
> 
> 
> 

See tools/makeinst-script.sh, line 526:

; didnt remove directory ? most likely from not all files removed
 IfErrors 0 uninstall_done
    MessageBox MB_YESNO "One or more folders were not uninstalled because
they contain extra files. Try to delete them?" /SD IDYES IDNO uninstall_done
    RMDir /r "\$INSTDIR"

    IfErrors 0 uninstall_done
        MessageBox MB_YESNO "One of more files were still not uninstalled.
Do you want to delete them on the next reboot?" /SD IDYES IDNO
uninstall_done
        RMDir /r /REBOOTOK "\$INSTDIR"
uninstall_done: