On 1/13/19 1:35 PM, Andreas Weber wrote:
Am 12.01.19 um 10:53 schrieb Andrew Janke:
You're welcome, glad to help. If you plan to implement datetime for
Octave I would suggest to use to use endfunction, endswitch,
endproperties, endmethods and so on for better readability.
-- Andy
Yep, I'll switch the style over to the GNU Octave style before
submitting it. I'm just not a fan of that style personally, so I'm
going to keep it in Matlab style while it's under development.
My point was that you would have found the problematic end yourself
(or at least it would have been easier for me) if you would have used
endswitch, endfunction, endmethods. In my eyes this Octave addition is
not only "style" but a way to increase readability.
-- Andy
PS: I saw you've removed datetime.m from your repo? Why
Fair point. I'm pretty reliant on Matlab's auto-formatting for the same
thing.
I'll consider switching over.
I moved datetime to a separate repo that is now structured as an Octave
pkg project: https://github.com/apjanke/octave-addons-chrono. That'll
make it easier to work with, and make sure dependencies on the other
bits of code (like string/ and misc/) in my main octave-addons don't
creep in to it.
Cheers,
Andrew