[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Removing ATOMIC_REFCOUNT remainders from build system?

From: Rik
Subject: Removing ATOMIC_REFCOUNT remainders from build system?
Date: Fri, 11 Oct 2019 09:39:33 -0700


Since you re-built the atomic operations atop C++ std::atomic, there
doesn't seem to be any use for OCTAVE_ENABLE_ATOMIC_REFCOUNT.  Should the
remaining vestiges in configure.ac, toplev.cc, oct-conf-post.in.h,
mk-octave-config-h.sh be removed?

Alternatively, we could re-instate the functionality in oct-refcount.h

    std::atomic<T> m_count;
  T m_count;

This would mostly be of use in determining the penalty we pay for
cross-thread communication.  It might be useful if we eventually attempt an
optimization such that only objects which are traveling cross-thread use
the atomic interface.  But, this is speculative so I'm also fine with just
removing it.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]