[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Deprecate sizemax() ?
Deprecate sizemax() ?
Sun, 27 Oct 2019 10:46:25 -0700
I was investigating a very old bug where the ones() function was able (sort
of) to create an array where the number of elements was greater than
sizemax() (see https://savannah.gnu.org/bugs/index.php?47468). It turns
out that Octave was doing something rather clever. For row vectors (1xN
objects), ones() was substituting a Range object rather than an NDArray. A
Range object requires constant storage (24B) versus an Array object (8 *
numel (x)). Since constant arrays are often built by C*ones(...), this has
more applicability than one might think. This seemed like a good feature
that should apply to all of the constant array functions such as zeros(),
pi(), e() as well so I made that change
However, now there is the remaining problem that all of these function can
create arrays larger than sizemax(). Is the sizemax() constraint, as
opposed to the limit of the underlying representation which is
octave_idx_type and is either intmax ('int32') or intmax ('int64')
depending on how Octave was built, truly necessary anymore? There is
another bug report that says the value of sizemax is off by one
(https://savannah.gnu.org/bugs/?47469) which is related. Originally, there
seems to have been a desire to facilitate the construction of 2-D sparse
arrays from full arrays. But my thinking is that the implementation of one
particular object type should not affect the API for all Octave object's.
If the hard requirement for sparse arrays is that numel (x) <= intmax
(octave_idx_type) - 1 then that can be checked in the constructor for those
objects, but other routines shouldn't require this.
This is foundational--a change to the API--which is why I'm asking about it
on the Maintainer's list. In practice, this isn't much of an issue. Most
modern builds enable 64-bit indexing and the difference between being able
to create arrays with 2^63 - 1 elements versus 2^63 - 2 is largely
theoretical. After all, there are few machines that have 2^63 * 8B =
7.38e19 B of RAM available.
- Deprecate sizemax() ?,