Re: Octave 5.2.0 release

[Markus Mützel]

Am 15. Januar 2020 um 06:54 Uhr schrieb "Kai Torben Ohlhus":
> On 1/15/20 12:17 PM, Kai Torben Ohlhus wrote:
> > On 1/15/20 2:07 AM, "Markus Mützel" wrote:
> >>
> >> I installed with the w64 installer on Windows 10 and tried to run the test 
> >> suite. Octave closed unexpectedly with the following at the tail of 
> >> fntests.log:
> >>>>>>> processing 
> >>>>>>> C:\Octave\OCTAVE~2.90\mingw64\share\octave\5.1.90\etc\tests\fixed\single-index.tst
> >>>>>>> processing 
> >>>>>>> C:\Octave\OCTAVE~2.90\mingw64\share\octave\5.1.90\etc\tests\fixed\slice.tst
> >>>>>>> processing 
> >>>>>>> C:\Octave\OCTAVE~2.90\mingw64\share\octave\5.1.90\etc\tests\fixed\sparse.tst
> >>
> >> This might be something we already fixed on default (hg id 1a75fca6ad5d, 
> >> mlock for the SuiteSparse functions). That change should maybe be grafted 
> >> to stable if possible.
> > 
> > Markus, thank you for testing.  This is indeed serious
> > (https://savannah.gnu.org/bugs/?57435) and I confirmed today myself at
> > work with my MS Windows machine.
> > 
> > Now I create a quick & dirty build with the grafted cset and publish it on
> > 
> >    https://octave.space
> > 
> > soon.  If this helps, I create "official" 5.1.91 builds and then let the
> > final testing continue.
> > 
> >> Also, the installer appears blurry on a HiDPI screen (see attachment). 
> >> Compare the text in the title bar and the text inside the window.
> >> I don't know if there is something we can do about this or if this has to 
> >> be fixed upstream in NSIS.
> >>
> >> Markus
> >>
> > 
> > Reported at https://savannah.gnu.org/bugs/?57600.  Additionally, I build
> > the quick & dirty build with the following patch:
> > 
> > 
> > diff -r 92b6fce85f02 tools/makeinst-script.sh.in
> > --- a/tools/makeinst-script.sh.in   Mon Jan 13 09:54:00 2020 -0500
> > +++ b/tools/makeinst-script.sh.in   Wed Jan 15 12:11:56 2020 +0900
> > @@ -92,6 +92,7 @@
> >  XPStyle on
> >  InstallDir "C:\\Octave\\Octave-\${OCTAVE_VERSION}"
> >  Icon "\${INSTALLER_FILES}/octave-logo.ico"
> > +ManifestDPIAware true
> > 
> >  ######################################################################
> >  ; StrFunc usage
> > 
> > See if it helps or disturbs other DPI settings.
> > 
> > Kai
> > 
> 
> Good news, Markus, grafting your fix for bug #57600 works perfect for
> stable, at least on my MS Win10 machine.  Thus I make it official in the
> repo.  Thanks for the pointer.
> 
> [...]
> 
>   fixed\sparse.tst ........................ PASS 1204/1204
> 
> [...]
> 
> Summary:
> 
>   PASS                            15496
>   FAIL                                0
>   XFAIL (reported bug)               28
>   SKIP (missing feature)             52
>   SKIP (run-time condition)          39
> 
> Can you check if the HiDPI problem was solved with the new installer as
> well?  All available on:
> 
>    https://octave.space

Thanks for providing an updated build.

Unfortunately, the text in the installer still appears blurry on a HiDPI 
monitor (see attachment).

The test suite now no longer crashes Octave. So that's good. :-)
I have one failing test:
>>>>> processing 
>>>>> C:\Octave\OCTAVE~2.90\mingw64\share\octave\5.1.90\etc\tests\libinterp\corefcn\graphics.cc-tst
***** test
 hf = figure ("visible", "off");
 hax = axes ("parent", hf);
 unwind_protect
   hctx1 = uicontextmenu ("parent", hf);
   hctx2 = uicontextmenu ("parent", hf);
   set (hf, "uicontextmenu", hctx2);
   set (hax, "uicontextmenu", hctx2);
   assert (get (hf, "uicontextmenu"), hctx2);
   assert (get (hax, "uicontextmenu"), hctx2);
   assert (get (hf, "children"), [hctx2; hctx1; hax]);
   delete (hctx2);
   assert (get (hf, "uicontextmenu"), []);
   assert (get (hax, "uicontextmenu"), []);
   assert (get (hf, "children"), [hctx1; hax]);
   set (hf, "uicontextmenu", hctx1);
   assert (get (hf, "uicontextmenu"), hctx1);
   set (hf, "uicontextmenu", []);
   assert (get (hf, "uicontextmenu"), []);
   assert (get (hf, "children"), [hctx1; hax]);
 unwind_protect_cleanup
   close (hf);
 end_unwind_protect;
!!!!! test failed
ASSERT errors for:  assert (get (hf, "uicontextmenu"),[])

  Location  |  Observed  |  Expected  |  Reason
     .          O(1x1)       E(0x0)      Dimensions don't match

But if I remember correctly, that one is due to a timing issue and failed 
intermittently before. So not a regression.

Markus

Installer_blurry_2020-01-15.PNG
Description: PNG image