[Octave-patch-tracker] [patch #7468] Wrapper for OSX libBLAS.dylib and libLAPACK.dylib

[anonymous]

Follow-up Comment #2, patch #7468 (project octave):

I do not object any of the changes you propose.

f2c_lapack_func is an array of function pointers. +1 in the array *definition*
makes the array one element larger, so that when (an unused) stub for
f2c_LAPACK_COUNT is created, the compiler does not warn about dereferencing
f2c_lapack_func[f2c_LAPACK_COUNT].

BUT now that I think about this again, it would be cleaner to define:

#define F2C_LAPACK_CALL_NONE(name)

i.e. an empty macro body, and then replace the line:

  _(LAPACK_COUNT,0)

with

  _(LAPACK_COUNT,NONE)

This way f2c_lapack_func[f2c_LAPACK_COUNT] would never be used, and hence no
warning either :-)

I have attached an updated blaswrap.c to this effect. The file is also
untabified and has no C++ comments :-)


(file #22779)
    _______________________________________________________

Additional Item Attachment:

File name: blaswrap.c                     Size:9 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?7468>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/