[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #7649] new function narginchk

From: John W. Eaton
Subject: [Octave-patch-tracker] [patch #7649] new function narginchk
Date: Fri, 28 Oct 2011 17:01:27 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0.2) Gecko/20100101 Firefox/6.0.2 Iceweasel/6.0.2

Follow-up Comment #1, patch #7649 (project octave):

You need to do a few more things to properly add a function to Octave.  The
file must be listed in the appropriate scripts/*/module.mk file and a tag for
the docstring should be added to some appropriate place in one of the manual's
.txi source files.

I don't think @seealso should refer to functions that we don't have, so please
remove inputParser from the list.

Doc strings should start with a statement that is like a command, so "Check
for ...", not "Checks for ..."

"hev" in the docstring should be "have"?

Why do you split the evalin call across multiple lines?

To be consistent with the rest of Octave, please use double quotes for
character strings unless there is a specific need to use single quotes.

There is no need to put your email address in the Copyright line, but if you
would like to add an "## Author: " line, after the docstring and just before
the function line, it can go there.  See other functions for an example.

Please don't put spaces after "(" or before ")".  So write

if (nargin != 2)


if ( nargin != 2 )

Could you please update your changeset and attach it again?



Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]