[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-patch-tracker] [patch #7752] Add support for saving and loading

From: Ben Abbott
Subject: [Octave-patch-tracker] [patch #7752] Add support for saving and loading figures
Date: Mon, 26 Mar 2012 21:15:13 +0000
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_3) AppleWebKit/535.11 (KHTML, like Gecko) Chrome/17.0.963.83 Safari/535.11

Follow-up Comment #1, patch #7752 (project octave):

Looks like a good start. The coding looks to be consistent with Octave's
standard. I suggest you add a copyobj.m


And include some tests. That will allow both hdl2struct.m and struct2hdl.m to
be tested simultaneously. You can also include tests you know will fail. For
those be sure to mark them as expected failures so that the remaining tests
will run.

I like how this is organized as handle-to-structure and structure-to-handle.
That will permit a figure to be saved by.

fig = hdl2struct (gcf ());
save plot.fig -struct fig

When you have time, you may want to add the tex-info doc strings. If you're
not familiar with tex-info you can look at some of Octave's functions.
Experience with LaTeX will help. Or you can ask for some help on the
maintainers list.

Also you may want to include a TODO list in the source of each file so that
anyone looking, and inclined to help, out knows what else needs to be done.

I see in the "getprops()" function you list properties to avoid copying. I've
thought about this problem myself. I'm not sure if it is best to list those
*not* to copy, or list those that *should* be copied. In either case, it looks
like there may be some difficulty with maintenance. I don't see any reason to
question your choice, but I expect the question to come up. Maybe someone can
come up with a way to construct the list automatically?

If there are any specifics you are unsure about, please ask.

I'll also respond on the mail-list.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]