[Octave-patch-tracker] [patch #7857] Replace dynamic casts of GUI/IDE editor with more slots/signals configuration

[Dan Sebald]

Follow-up Comment #20, patch #7857 (project octave):

Give the attached patch a try.  It used to be that the to-be-saved file was
removed from watch after open but before save.  I moved the watch file removal
to before file.open ().  My thinking is that opening a file could be, by some
definitions, a change of file on disk.  Perhaps Qt developers made a subtle
change regarding that detail between versions.

[now appears before file.open]
  // stop watching file
  QStringList trackedFiles = _file_system_watcher.files ();
  if (!trackedFiles.isEmpty ())
    _file_system_watcher.removePath (saveFileName);

  // open the file for writing
  QFile file (saveFileName);
  if (!file.open (QIODevice::WriteOnly))
    {
[added this and confirmed it works be opening a read-only file and attempting
a save]
      // Unsuccessful, begin watching file again if it was being
      // watched previously.
      if (trackedFiles.contains (saveFileName))
        _file_system_watcher.addPath (saveFileName);



(file #26880)
    _______________________________________________________

Additional Item Attachment:

File name: octave-gui_no_casts-2012nov06.patch Size:80 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?7857>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/