[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-patch-tracker] [patch #7934] Adding tests for operator overloadi
Jordi Gutiérrez Hermoso
[Octave-patch-tracker] [patch #7934] Adding tests for operator overloading in the legacy class system (bug #38128)
Mon, 28 Jan 2013 16:39:33 +0000
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:126.96.36.199) Gecko/20110109 Sparklemming/3.6.13
Update of patch #7934 (project octave):
Status: None => Need Info
Follow-up Comment #1:
Can you please explain these lines?
+%% Note(JBect, 2013/01/27) : in order to ease to process of testing
+%% Matlab compatibility, the syntax assert(observed, expected) should
+%% be avoided. I use assert(isequal(observed, expected) instead.
We don't generally care if Octave code runs in Matlab. Tests are just Octave
code. Using ugly syntax just to please Matlab is very much not what we
generally do. Are you just doing this because Matlab doesn't have a
two-argument version of assert?
Furthermore, I'm not sure about your decision to put these tests on stable.
It may be ok. After all, they are just tests. On the other hand, we try to be
extremely conservative about patching on stable, and new tests could
potentially break packagers' build scripts if they expect a clean-ish exit
from "make check".
Reply to this item at:
Message sent via/by Savannah